[O2B-1536] Pass EOR lastEditedName through RunPatch

Stop keeping a separate `eorReasonLastEditedNames` list on RunDetailsModel and instead include `lastEditedName` on each eorReason within RunPatch.

RunPatch `toPojo` then strips that field when building the outbound patch.

This removes duplicate state and ensures only allowed fields are sent to the server.

Author: isaachilly

lib/public/views/Runs/Details/RunDetailsModel.js

@@ -53,8 +53,6 @@ export class RunDetailsModel extends Observable {
         this.editionTagPickerModel = new TagSelectionDropdownModel();
         this._runPatch = new RunPatch();
         this._runPatch.bubbleTo(this);
-        this._eorReasonLastEditedNames = [];
-
         this._tabbedPanelModel = new RunDetailsTabbedPanelModel();
         this._tabbedPanelModel.bubbleTo(this);
 
@@ -279,14 +277,6 @@ export class RunDetailsModel extends Observable {
         return this._runPatch;
     }
 
-    /**
-     * Returns the list of last edited names for EOR reasons, to be displayed in the edit form so as not to get added to patch
-     * @return {string[]} the list of last edited names for EOR reasons
-     */
-    get eorReasonLastEditedNames() {
-        return this._eorReasonLastEditedNames;
-    }
-
     /**
      * Returns the model for bottom-page tabs
      *
@@ -310,8 +300,6 @@ export class RunDetailsModel extends Observable {
             this._runPatch = new RunPatch(run);
             this._runPatch.bubbleTo(this);
 
-            this._eorReasonLastEditedNames = (run.eorReasons || []).map((eorReason) => eorReason.lastEditedName ?? null);
-
             this.editionTagPickerModel = new TagSelectionDropdownModel({ defaultSelection: run.tags.map(tagToOption) });
             this._tabbedPanelModel.runNumber = run.runNumber;
             this._runNumber = run.runNumber;

lib/public/views/Runs/Details/RunPatch.js

@@ -9,6 +9,7 @@ import { RunQualities } from '../../../domain/enums/RunQualities.js';
  * @property {string} category
  * @property {string} title
  * @property {string} description
+ * @property {string|null} [lastEditedName]
  */
 
 /**
@@ -75,7 +76,8 @@ export class RunPatch extends Observable {
         }
 
         if (this._eorReasons.length !== this._run.eorReasons.length || this._eorReasons.some(({ id }) => id === undefined)) {
-            ret.eorReasons = this._eorReasons;
+            // Strip lastEditedName — the server's EorReasonDto only accepts id, reasonTypeId, and description
+            ret.eorReasons = this._eorReasons.map(({ id, reasonTypeId, description }) => ({ id, reasonTypeId, description }));
         }
 
         if (this._hasRunQualityChange()) {
@@ -126,10 +128,11 @@ export class RunPatch extends Observable {
         } = this._run || {};
 
         this._runQuality = runQuality;
-        this._eorReasons = eorReasons.map(({ id, description, reasonTypeId }) => ({
+        this._eorReasons = eorReasons.map(({ id, description, reasonTypeId, lastEditedName }) => ({
             id,
             description,
             reasonTypeId,
+            lastEditedName,
         }));
         this._tags = tags.map(({ text }) => text);
 

lib/public/views/Runs/format/editRunEorReasons.js

@@ -93,9 +93,8 @@ export const editRunEorReasons = (runDetailsModel) => {
                  * added EOR reason is still displayed
                  */
                 runDetailsModel.runPatch.eorReasons.length > 0
-                    ? runDetailsModel.runPatch.eorReasons.map((eorReason, index) => {
-                        const { reasonTypeId, description } = eorReason;
-                        const lastEditedName = runDetailsModel.eorReasonLastEditedNames[index];
+                    ? runDetailsModel.runPatch.eorReasons.map((eorReason) => {
+                        const { reasonTypeId, description, lastEditedName } = eorReason;
                         const { category = '-', title } = eorReasonTypes.find((eorReasonType) => eorReasonType.id === reasonTypeId) || {};
                         const titleString = title ? ` - ${title}` : '';
                         const descriptionString = description ? ` - ${description}` : '';
@@ -111,7 +110,7 @@ export const editRunEorReasons = (runDetailsModel) => {
                                     }, iconTrash()),
                                     h('.w-wrapped', `${category} ${titleString} ${descriptionString}`),
                                 ]),
-                                h('.w-wrapped', `${lastEditedName ? `${lastEditedName}` : ''}`),
+                                h('.w-wrapped', lastEditedName || ''),
                             ],
                         );
                     })

lib/public/views/Runs/format/eorReasonComponent.js

@@ -31,6 +31,6 @@ export const eorReasonComponent = (eorReason) => {
     const reasonText = formatEorReason(eorReason);
     return h('.w-100.flex-row.justify-between', [
         h('', reasonText),
-        tooltip(h('.w-wrapped', `${lastEditedName}`), 'Last edited by'),
+        lastEditedName ? tooltip(h('.w-wrapped', lastEditedName), 'Last edited by') : '',
     ]);
 };