Skip to content

Commit 19b6866

Browse files
author
NarrowsProjects
committed
EXPERIMENT: undo changes for GetAllLogsUseCase
1 parent 2a48c02 commit 19b6866

1 file changed

Lines changed: 21 additions & 13 deletions

File tree

lib/usecases/run/GetAllRunsUseCase.js

Lines changed: 21 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ const { DetectorType } = require('../../domain/enums/DetectorTypes.js');
2626
const { unpackNumberRange } = require('../../utilities/rangeUtils.js');
2727
const { splitStringToStringsTrimmed } = require('../../utilities/stringUtils.js');
2828
const { setTimeRangeQuery } = require('../../utilities/setTimeRangeQuery.js');
29-
const { runSummary } = require('../../server/views/runs/summary.js');
29+
const { OldQueryBuilder } = require('../../database/utilities/OldQueryBuilder.js');
3030

3131
/**
3232
* GetAllRunsUseCase
@@ -39,7 +39,7 @@ class GetAllRunsUseCase {
3939
* @return {Promise} Promise object represents the result of this use case.
4040
*/
4141
async execute(dto = {}) {
42-
const filteringQueryBuilder = new QueryBuilder();
42+
const filteringQueryBuilder = new OldQueryBuilder();
4343
const { query = {} } = dto;
4444
const { filter, page = {}, sort = { runNumber: 'desc' }, include: { effectiveQcFlags = false } = {} } = query;
4545

@@ -491,10 +491,19 @@ class GetAllRunsUseCase {
491491
}
492492
const { count, rows } = await RunRepository.findAndCountAll(filteringQueryBuilder);
493493

494-
const fetchQueryBuilder = new QueryBuilder();
495-
fetchQueryBuilder.selectAttributes([...runSummary.attributes]);
496-
fetchQueryBuilder.includeAll([...runSummary.include]);
497-
494+
const fetchQueryBuilder = new OldQueryBuilder();
495+
fetchQueryBuilder.include({ association: 'runType' });
496+
fetchQueryBuilder.include({ association: 'lhcFill' });
497+
fetchQueryBuilder.include({ association: 'tags' });
498+
fetchQueryBuilder.include({ association: 'detectors' });
499+
fetchQueryBuilder.include({
500+
association: 'eorReasons',
501+
include: {
502+
association: 'reasonType',
503+
attributes: ['category', 'title'],
504+
},
505+
});
506+
fetchQueryBuilder.include({ association: 'lhcPeriod' });
498507
fetchQueryBuilder.where('id').oneOf(...rows.map(({ id }) => id));
499508
for (const property in sort) {
500509
fetchQueryBuilder.orderBy(property, sort[property]);
@@ -516,7 +525,6 @@ class GetAllRunsUseCase {
516525

517526
const qcFlagsAssociationDef = {
518527
association: 'qcFlags',
519-
attributes: ['id', 'detectorId'],
520528
required: false,
521529
separate: true,
522530
order: [['from', 'ASC']],
@@ -528,10 +536,10 @@ class GetAllRunsUseCase {
528536
)`),
529537
] },
530538
include: [
531-
{ association: 'effectivePeriods', required: true, separate: true, attributes: ['from', 'to'] },
532-
{ association: 'flagType', attributes: ['name'] },
533-
{ association: 'detector', attributes: ['name'], required: true },
534-
{ association: 'createdBy', attributes: [], required: true },
539+
{ association: 'effectivePeriods', required: true, separate: true },
540+
{ association: 'flagType' },
541+
{ association: 'detector', required: true },
542+
{ association: 'createdBy' },
535543
],
536544
};
537545

@@ -550,9 +558,9 @@ class GetAllRunsUseCase {
550558
}
551559
}
552560

553-
const runs = await RunRepository.findAll(fetchQueryBuilder);
561+
const runs = (await RunRepository.findAll(fetchQueryBuilder)).map(runAdapter.toEntity);
554562

555-
return { count, runs: runs.map(runAdapter.toSummary) };
563+
return { count, runs };
556564
}
557565
}
558566

0 commit comments

Comments
 (0)