Update SYNTHETIC run definition

Author: graduta

docs/RUN_DEFINITIONS.md

@@ -47,7 +47,7 @@ During technical runs, the processes are reading the front-end electronics;
 
 ### SYNTHETIC: 
 During synthetic runs, the processes are at the level of readout and emulate readout;
-- `readout_cfg_uri` to include (`pp` or `pbpb`) and `replay`
+- `run_type` set to `SYNTHETIC` or `REPLAY`
 - `dcs` = `false`
 - `trigger_value` = `OFF`
 
@@ -56,3 +56,11 @@ During synthetic runs, the processes are at the level of readout and emulate rea
 
 ### COMMISIONING:
 - any run that does not fit any of the prior definitions;
+
+## Previous RUN Definitions
+
+### SYNTHETIC: (RUNS marked before @aliceo2/bookkeeping@1.10.0)
+During synthetic runs, the processes are at the level of readout and emulate readout;
+- `readout_cfg_uri` to include (`pp` or `pbpb`) and `replay`
+- `dcs` = `false`
+- `trigger_value` = `OFF`

lib/server/services/run/getRunDefinition.js

@@ -36,7 +36,6 @@ const getRunDefinition = (run) => {
         pdpWorkflowParameters,
         runType,
         pdpBeamType,
-        readoutCfgUri,
         lhcBeamMode,
     } = run;
 
@@ -79,8 +78,7 @@ const getRunDefinition = (run) => {
     } else if (
         !dcs
         && triggerValue === 'OFF'
-        && readoutCfgUri?.includes('replay')
-        && readoutCfgUri?.match('pp|pbpb')
+        && (runType?.name?.match(/^replay$/i) || runType?.name?.match(/^synthetic$/i))
     ) {
         definition = RunDefinition.SYNTHETIC;
     } else if (CALIBRATION_RUN_TYPES_STARTS_WITH.some((prefix) => runType?.name?.toUpperCase().startsWith(prefix))) {

test/lib/server/services/run/RunService.test.js

@@ -141,7 +141,7 @@ module.exports = () => {
 
     it('should successfully prevent to create a non-calibration run with a calibrationStatus', async () => {
         await assert.rejects(
-            () => runService.create({ ...SYNTHETIC.PBPB, calibrationStatus: RunCalibrationStatus.SUCCESS }),
+            () => runService.create({ ...SYNTHETIC.SYNTHETIC, calibrationStatus: RunCalibrationStatus.SUCCESS }),
             new BadParameterError('Calibration status is reserved to calibration runs'),
         );
     });

test/lib/server/services/run/getRunDefinition.test.js

@@ -39,8 +39,8 @@ module.exports = () => {
     });
 
     it('should successfully identify runs as SYNTHETIC', () => {
-        expect(getRunDefinition(SYNTHETIC.PP)).to.equal(RunDefinition.SYNTHETIC);
-        expect(getRunDefinition(SYNTHETIC.PBPB)).to.equal(RunDefinition.SYNTHETIC);
+        expect(getRunDefinition(SYNTHETIC.REPLAY)).to.equal(RunDefinition.SYNTHETIC);
+        expect(getRunDefinition(SYNTHETIC.SYNTHETIC)).to.equal(RunDefinition.SYNTHETIC);
     });
 
     it('should successfully identify runs as CALIBRATION', () => {

test/mocks/mock-run.js

@@ -170,14 +170,13 @@ module.exports = {
         },
     },
     SYNTHETIC: {
-        PP: {
+        REPLAY: {
             dcs: false,
             dd_flp: true,
             epn: true,
             triggerValue: 'OFF',
             tfbDdMode: 'processing',
             pdpWorkflowParameters: 'QC,CTF',
-            readoutCfgUri: 'replay/pp',
             lhcFill: {
                 stableBeamsStart: '2022-10-01T10:00:00',
                 stableBeamsEnd: '2022-10-02T10:00:00',
@@ -186,17 +185,16 @@ module.exports = {
             timeTrgEnd: 1664625600000, // 2022-10-01T14:00:00
             concatenatedDetectors: 'TPC, TST',
             runType: {
-                name: 'TECHNICAL',
+                name: 'REPLAY',
             },
         },
-        PBPB: {
+        SYNTHETIC: {
             dcs: false,
             dd_flp: true,
             epn: true,
             triggerValue: 'OFF',
             tfbDdMode: 'processing',
             pdpWorkflowParameters: 'QC,CTF',
-            readoutCfgUri: 'replay/pbpb',
             lhcFill: {
                 stableBeamsStart: '2022-10-01T10:00:00',
                 stableBeamsEnd: '2022-10-02T10:00:00',
@@ -205,7 +203,7 @@ module.exports = {
             timeTrgEnd: 1664625600000, // 2022-10-01T14:00:00
             concatenatedDetectors: 'TPC, TST',
             runType: {
-                name: 'TECHNICAL',
+                name: 'SYNTHETIC',
             },
         },
     },