use undefined periods count

Author: xsalonx

lib/database/repositories/QcFlagRepository.js

@@ -119,7 +119,7 @@ class QcFlagRepository extends Repository {
                     NULL) AS significance,
                 GROUP_CONCAT( DISTINCT qcfv.flag_id )                     AS verified_flags_list,
                 GROUP_CONCAT( DISTINCT qcfep.flag_id )                    AS flags_list,
-                COUNT(DISTINCT gaqd.detector_id) - COUNT(DISTINCT qcf.id) AS undefined_quality_periods_count,
+                COUNT(DISTINCT gaqd.detector_id) - COUNT(DISTINCT qcf.id) AS undefined_quality_periods_count
 
             FROM gaq_periods
 

lib/public/views/Runs/RunPerDataPass/RunsPerDataPassOverviewPage.js

@@ -186,12 +186,8 @@ export const RunsPerDataPassOverviewPage = ({
                         visible: true,
                         format: (_, { runNumber }) => {
                             const runGaqSummary = gaqSummary[runNumber];
-                            const FULL_COVERAGE = 1;
-                            const coverageEpsilon = 1e-6;
-                            const totalCoverage = (runGaqSummary?.badEffectiveRunCoverage ?? 0) +
-                                (runGaqSummary?.explicitlyNotBadEffectiveRunCoverage ?? 0);
 
-                            const gaqDisplay = totalCoverage >= FULL_COVERAGE - coverageEpsilon
+                            const gaqDisplay = runGaqSummary?.undefinedQualityPeriodsCount === 0
                                 ? getQcSummaryDisplay(runGaqSummary)
                                 : h('button.btn.btn-primary.w-100', 'GAQ');
 

test/api/runs.test.js

@@ -399,33 +399,6 @@ module.exports = () => {
 
         it('should successfully filter by GAQ notBadFraction', async () => {
             const dataPassId = 1;
-            const runNumber = 107;
-            const commonScopte = {
-                runNumber,
-                dataPassIdentifier: { id: dataPassId },
-            };
-            const relations = { user: { roles: ['admin'], externalUserId: 1 } };
-            // eslint-disable-next-line require-jsdoc
-            const t = (timeString) => new Date(`2019-08-08 ${timeString}`).getTime();
-            const goodFlagTypeId = 3;
-            const mcReproducibleFlagTypeId = 11;
-            let createdFlagIds = [];
-
-            let flagIds = await qcFlagService.create(
-                [{ from: null, to: null, flagTypeId: goodFlagTypeId }],
-                { ...commonScopte, detectorIdentifier: { detectorName: 'EMC' } },
-                relations,
-            );
-            createdFlagIds = [...createdFlagIds, ...flagIds];
-
-            flagIds = await qcFlagService.create(
-                [{ from: null, to: t('13:30:00'), flagTypeId: goodFlagTypeId }],
-                [{ from: t('13:30:00'), to: null, flagTypeId: mcReproducibleFlagTypeId }],
-                { ...commonScopte, detectorIdentifier: { detectorName: 'CPV' } },
-                relations,
-            );
-            createdFlagIds = [...createdFlagIds, ...flagIds];
-
             {
                 const response = await request(server).get(`/api/runs?filter[dataPassIds][]=${dataPassId}&filter[gaq][notBadFraction][<]=0.8`);
 
@@ -445,8 +418,6 @@ module.exports = () => {
                 expect(runs).to.be.an('array');
                 expect(runs).to.have.lengthOf(0);
             }
-
-            await Promise.all(createdFlagIds.map((flagId) => qcFlagService.delete(flagId)));
         });
 
         it('should return http status 400 if updatedAt from larger than to', async () => {