Fetch items only when needed

Author: graduta

lib/public/views/Runs/Overview/RunsWithQcModel.js

@@ -70,6 +70,7 @@ export class RunsWithQcModel extends RunsOverviewModel {
     constructor(model) {
         super(model);
 
+        this._observablesQcFlagsSummaryDependsOn$ = null;
         this._mcReproducibleAsNotBad = false;
 
         this._runDetectorsSelectionModel = new RunDetectorsSelectionModel();
@@ -131,7 +132,10 @@ export class RunsWithQcModel extends RunsOverviewModel {
      */
     async load() {
         this._runDetectorsSelectionModel.reset();
-        this._fetchQcSummary();
+        // Only fetch QC summary manually if no observer is registered
+        if (!this._observablesQcFlagsSummaryDependsOn$) {
+            this._fetchQcSummary();
+        }
         super.load();
     }
 
@@ -171,14 +175,10 @@ export class RunsWithQcModel extends RunsOverviewModel {
     /**
      * Register observables data, which QC flags fetching operation success depends on
      *
-     * @param {ObservableData<RemoteData>[]} observables observable data list
+     * @param {ObservableData<RemoteData<Detector>>} detectors$ observable data which QC flags fetching operation success depends on
      */
-    registerObservablesQcSummaryDependsOn(observables) {
-        this._observablesQcFlagsSummaryDependsOn$ = ObservableData
-            .builder()
-            .sources(observables)
-            .apply((remoteDataList) => mergeRemoteData(remoteDataList))
-            .build();
+    registerObservablesQcSummaryDependsOn(detectors$) {
+        this._observablesQcFlagsSummaryDependsOn$ = detectors$;
 
         this._observablesQcFlagsSummaryDependsOn$
             .observe((observableData) => observableData.getCurrent().apply({ Success: () => this._fetchQcSummary() }));

lib/public/views/Runs/RunPerDataPass/RunsPerDataPassOverviewModel.js

@@ -54,7 +54,7 @@ export class RunsPerDataPassOverviewModel extends FixedPdpBeamTypeRunsOverviewMo
         this._detectors$.bubbleTo(this);
         this.registerDetectorsNotBadFractionFilterModels(this._detectors$);
         this.registerDetectorsForQcFlagsDataExport(this._detectors$);
-        this.registerObservablesQcSummaryDependsOn([this._detectors$]);
+        this.registerObservablesQcSummaryDependsOn(this._detectors$);
 
         this._markAsSkimmableRequestResult$ = new ObservableData(RemoteData.notAsked());
         this._markAsSkimmableRequestResult$.bubbleTo(this);

lib/public/views/Runs/RunPerPeriod/RunsPerLhcPeriodOverviewModel.js

@@ -50,7 +50,7 @@ export class RunsPerLhcPeriodOverviewModel extends FixedPdpBeamTypeRunsOverviewM
             .build();
 
         this.registerDetectorsForQcFlagsDataExport(this._syncDetectors$);
-        this.registerObservablesQcSummaryDependsOn([this._syncDetectors$]);
+        this.registerObservablesQcSummaryDependsOn(this._syncDetectors$);
 
         this._syncDetectors$.bubbleTo(this);
         this._onlineDetectors$.bubbleTo(this);

lib/public/views/Runs/RunsPerSimulationPass/RunsPerSimulationPassOverviewModel.js

@@ -31,7 +31,7 @@ export class RunsPerSimulationPassOverviewModel extends FixedPdpBeamTypeRunsOver
 
         this._detectors$ = rctDetectorsProvider.qc$;
 
-        this.registerObservablesQcSummaryDependsOn([this._detectors$]);
+        this.registerObservablesQcSummaryDependsOn(this._detectors$);
         this.registerDetectorsNotBadFractionFilterModels(this._detectors$);
         this.registerDetectorsForQcFlagsDataExport(this._detectors$);