a

Author: xsalonx

lib/public/views/Runs/RunPerPeriod/RunsPerLhcPeriodOverviewModel.js

@@ -101,6 +101,16 @@ export class RunsPerLhcPeriodOverviewModel extends RunsWithQcModel {
         this._tabbedPanelModel.lhcPeriodId = lhcPeriodId;
     }
 
+    /**
+     * Set mcReproducibleAsNotBad flag
+     *
+     * @param {boolean} mcReproducibleAsNotBad new value
+     */
+    setMcReproducibleAsNotBad(mcReproducibleAsNotBad) {
+        super.setMcReproducibleAsNotBad(mcReproducibleAsNotBad);
+        this._tabbedPanelModel.mcReproducibleAsNotBad = mcReproducibleAsNotBad;
+    }
+
     /**
      * Get all detectors
      *
@@ -155,7 +165,13 @@ class RunsPerLhcPeriodTabbedPanelModel extends TabbedPanelModel {
             this.currentPanelData = RemoteData.loading();
             this.notify();
             try {
-                const { data: qcSummary } = await jsonFetch(`/api/qcFlags/summary?lhcPeriodId=${this._lhcPeriodId}`);
+                const { data: qcSummary } = await jsonFetch(buildUrl(
+                    '/api/qcFlags/summary',
+                    {
+                        lhcPeriodId: this._lhcPeriodId,
+                        mcReproducibleAsNotBad: this._mcReproducibleAsNotBad,
+                    },
+                ));
                 this.currentPanelData = RemoteData.success(qcSummary);
             } catch (errors) {
                 this.currentPanelData = RemoteData.failure(errors);
@@ -167,10 +183,20 @@ class RunsPerLhcPeriodTabbedPanelModel extends TabbedPanelModel {
     /**
      * Set LHC period id
      *
-     * @param {string} lhcPeriodId id of LHC period
+     * @param {id} lhcPeriodId id of LHC period
      */
     set lhcPeriodId(lhcPeriodId) {
         this._lhcPeriodId = lhcPeriodId;
         this._fetchCurrentPanelData();
     }
+
+    /**
+     * Set mcReproducibleAsNotBad flag
+     *
+     * @param {boolean} mcReproducibleAsNotBad new value
+     */
+    set mcReproducibleAsNotBad(mcReproducibleAsNotBad) {
+        this._mcReproducibleAsNotBad = mcReproducibleAsNotBad;
+        this._fetchCurrentPanelData();
+    }
 }

lib/public/views/Runs/RunPerPeriod/RunsPerLhcPeriodOverviewPage.js

@@ -30,6 +30,7 @@ import { runNumbersFilter } from '../../../components/Filters/RunsFilter/runNumb
 import { mergeRemoteData } from '../../../utilities/mergeRemoteData.js';
 import errorAlert from '../../../components/common/errorAlert.js';
 import spinner from '../../../components/common/spinner.js';
+import { mcReproducibleAsNotBadToggle } from '../mcReproducibleAsNotBadToggle.js';
 
 const TABLEROW_HEIGHT = 62;
 // Estimate of the navbar and pagination elements height total; Needs to be updated in case of changes;
@@ -63,6 +64,7 @@ export const RunsPerLhcPeriodOverviewPage = ({ runs: { perLhcPeriodOverviewModel
         displayOptions,
         sortModel,
         tabbedPanelModel,
+        mcReproducibleAsNotBad,
     } = perLhcPeriodOverviewModel;
 
     /**
@@ -112,7 +114,10 @@ export const RunsPerLhcPeriodOverviewPage = ({ runs: { perLhcPeriodOverviewModel
                         filtersPanelPopover(perLhcPeriodOverviewModel, activeColumns, { profile: 'runsPerLhcPeriod' }),
                         h('.pl2#runOverviewFilter', runNumbersFilter(perLhcPeriodOverviewModel.filteringModel.get('runNumbers'))),
                         h('h2', `Good, physics runs of ${lhcPeriod.lhcPeriod.name}`),
-
+                        mcReproducibleAsNotBadToggle(
+                            mcReproducibleAsNotBad,
+                            () => perLhcPeriodOverviewModel.setMcReproducibleAsNotBad(!mcReproducibleAsNotBad),
+                        ),
                         exportRunsTriggerAndModal(perLhcPeriodOverviewModel, modalModel),
                     ]),
                     ...tabbedPanelComponent(

test/public/runs/runsPerLhcPeriod.overview.test.js

@@ -73,7 +73,7 @@ module.exports = () => {
     });
 
     it('loads the page successfully', async () => {
-        const response = await goToPage(page, 'runs-per-lhc-period', { queryParameters: { lhcPeriodName: 'LHC22a' } });
+        const response = await goToPage(page, 'runs-per-lhc-period', { queryParameters: { lhcPeriodId: 1 } });
 
         expect(response.status()).to.equal(200);
 
@@ -236,5 +236,19 @@ module.exports = () => {
         const expectedRunNumber = await getInnerText(await page.waitForSelector('tbody tr:first-of-type a'));
         await waitForNavigation(page, () => pressElement(page, 'tbody tr:first-of-type a'));
         expectUrlParams(page, { page: 'run-detail', runNumber: expectedRunNumber });
+        await page.goBack()
+    });
+
+    it('should successfully apply detectors notBadFraction filters', async () => {
+        await pressElement(page, '#openFilterToggle', true);
+
+        await page.waitForSelector('#inelasticInteractionRateAvg-operator');
+        await page.select('#inelasticInteractionRateAvg-operator', '<=');
+        await fillInput(page, '#inelasticInteractionRateAvg-operand', '100000', ['change']);
+        await expectColumnValues(page, 'runNumber', ['56', '54']);
+
+        await pressElement(page, '#openFilterToggle', true);
+        await pressElement(page, '#reset-filters', true);
+        await expectColumnValues(page, 'runNumber', ['105', '56', '54', '49']);
     });
 };