Skip to content

Commit 3ce2c51

Browse files
author
NarrowsProjects
committed
refactor: compact warning computation in setFilterFromURL
1 parent dcd336b commit 3ce2c51

1 file changed

Lines changed: 5 additions & 8 deletions

File tree

lib/public/components/Filters/common/FilteringModel.js

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -144,20 +144,17 @@ export class FilteringModel extends Observable {
144144
* @returns {undefined}
145145
*/
146146
setFilterFromURL(notify = false) {
147-
const { params: { page = '', filter } } = this._router;
147+
const { params: { page = '', filter = {} } } = this._router;
148148

149149
if (this._pageIdentifier === page) {
150150
const unknownFilters = [];
151151

152-
for (const [key, value] of Object.entries(filter)) {
153-
const filterModel = this._filters[key];
154-
155-
if (!filterModel) {
152+
for (const [key, value] of Object.entries(filter)) {
153+
if (key in _filters) {
154+
this._filters[key].normalized = value;
155+
} else {
156156
unknownFilters.push(`'${key}'`);
157-
continue;
158157
}
159-
160-
filterModel.normalized = value;
161158
}
162159

163160
if (unknownFilters.length) {

0 commit comments

Comments
 (0)