Skip to content

Commit 48c0dfd

Browse files
author
NarrowsProjects
committed
EXPERIMENT: undo changes for getAllEnvironments
1 parent 9fbbc9e commit 48c0dfd

2 files changed

Lines changed: 8 additions & 7 deletions

File tree

lib/database/utilities/OldQueryBuilder.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -635,4 +635,4 @@ class OldQueryBuilder extends QueryBuilder {
635635
}
636636
}
637637

638-
exports.OldQueryBuilder = OldQueryBuilder;
638+
exports.OldQueryBuilder = OldQueryBuilder;

lib/usecases/environment/GetAllEnvironmentsUseCase.js

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ const { statusAcronyms } = require('../../domain/enums/StatusAcronyms.js');
2424
const { unpackNumberRange } = require('../../utilities/rangeUtils.js');
2525
const { splitStringToStringsTrimmed } = require('../../utilities/stringUtils.js');
2626
const { setTimeRangeQuery } = require('../../utilities/setTimeRangeQuery.js');
27-
const { environmentSummary } = require('../../server/views/environments/summary.js');
2827

2928
/**
3029
* Subquery to select the latest history item for each environment.
@@ -71,7 +70,10 @@ class GetAllEnvironmentsUseCase {
7170
const { filter, page = {} } = query;
7271
const { limit = ApiConfig.pagination.limit, offset = 0 } = page;
7372

74-
const queryBuilder = dataSource.createQueryBuilder().orderBy('updatedAt', 'desc').limit(limit).offset(offset);
73+
const queryBuilder = dataSource.createQueryBuilder(true)
74+
.orderBy('updatedAt', 'desc')
75+
.limit(limit)
76+
.offset(offset);
7577

7678
if (filter) {
7779
const {
@@ -189,13 +191,12 @@ class GetAllEnvironmentsUseCase {
189191
}
190192
}
191193

192-
queryBuilder.selectAttributes([...environmentSummary.attributes]);
193-
queryBuilder.includeAll([...environmentSummary.include]);
194-
queryBuilder.pushOrders([...environmentSummary.order]);
194+
queryBuilder.include({ association: 'runs' });
195+
queryBuilder.include({ association: 'historyItems' });
195196
const { count, rows } = await EnvironmentRepository.findAndCountAll(queryBuilder);
196197
return {
197198
count,
198-
environments: rows.map((environment) => environmentAdapter.toSummary(environment)),
199+
environments: rows.map((environment) => environmentAdapter.toEntity(environment)),
199200
};
200201
}
201202
}

0 commit comments

Comments
 (0)