[O2B-1193] - Runs Per LHC Period export bugfix (#1455)

* fix edndpoint constracion

* add test

* amend

* t

* change selector

* extend test

* amend

* docs

* ch  paginaion

* linter

* use seeder data

* update

* Update test/utilities/waitForDownload.js

Co-authored-by: Martin Boulais <31805063+martinboulais@users.noreply.github.com>

---------

Co-authored-by: Martin Boulais <31805063+martinboulais@users.noreply.github.com>

Author: xsalonx

lib/public/views/Runs/Overview/RunsOverviewModel.js

@@ -957,9 +957,7 @@ export class RunsOverviewModel extends OverviewPageModel {
         this._allRuns = RemoteData.loading();
         this.notify();
 
-        const params = this._getFilterQueryParams();
-
-        const endpoint = `/api/runs?${new URLSearchParams(params).toString()}`;
+        const endpoint = this.getRootEndpoint();
 
         try {
             const { items } = await getRemoteDataSlice(endpoint);

test/public/runs/runsPerPeriod.overview.test.js

@@ -11,6 +11,8 @@
  * or submit itself to any jurisdiction.
  */
 
+const path = require('path');
+const fs = require('fs');
 const chai = require('chai');
 const {
     defaultBefore,
@@ -21,8 +23,10 @@ const {
     goToPage,
     reloadPage,
 } = require('../defaults');
-const { RUN_QUALITIES } = require('../../../lib/domain/enums/RunQualities.js');
+const { RUN_QUALITIES, RunQualities } = require('../../../lib/domain/enums/RunQualities.js');
 const { waitForTimeout } = require('../defaults.js');
+const { waitForDownload } = require('../../utilities/waitForDownload');
+const { RunDefinition } = require('../../../lib/server/services/run/getRunDefinition');
 
 const { expect } = chai;
 
@@ -199,4 +203,65 @@ module.exports = () => {
         expect(urlParameters).to.contain('page=run-detail');
         expect(urlParameters).to.contain(`runNumber=${expectedRunNumber}`);
     });
+
+    const EXPORT_RUNS_TRIGGER_SELECTOR = '#export-runs-trigger';
+
+    it('should successfully export all runs per lhc Period', async () => {
+        await goToPage(page, 'runs-per-lhc-period', { queryParameters: { lhcPeriodName: 'LHC22a' } });
+
+        const downloadPath = path.resolve('./download');
+
+        await page.evaluate(() => {
+            // eslint-disable-next-line no-undef
+            model.runs.perLhcPeriodOverviewModel.pagination.itemsPerPage = 2;
+        });
+
+        // Check accessibility on frontend
+        const session = await page.target().createCDPSession();
+        await session.send('Browser.setDownloadBehavior', {
+            behavior: 'allow',
+            downloadPath: downloadPath,
+            eventsEnabled: true,
+        });
+
+        const targetFileName = 'runs.json';
+
+        // First export
+        await pressElement(page, EXPORT_RUNS_TRIGGER_SELECTOR);
+        await page.waitForSelector('select.form-control', { timeout: 200 });
+        await page.select('select.form-control', 'runQuality', 'runNumber', 'definition', 'lhcPeriod');
+        await expectInnerText(page, '#send:enabled', 'Export');
+        await Promise.all([
+            waitForDownload(session),
+            pressElement(page, '#send:enabled'),
+        ]);
+
+        // Check download
+        const downloadFilesNames = fs.readdirSync(downloadPath);
+        expect(downloadFilesNames.filter((name) => name == targetFileName)).to.be.lengthOf(1);
+        const runs = JSON.parse(fs.readFileSync(path.resolve(downloadPath, targetFileName)));
+
+        expect(runs).to.have.all.deep.members([
+            {
+                runNumber: 49,
+                runQuality: RunQualities.GOOD,
+                definition: RunDefinition.Physics,
+                lhcPeriod: 'LHC22a',
+            },
+            {
+                runNumber: 54,
+                runQuality: RunQualities.GOOD,
+                definition: RunDefinition.Physics,
+                lhcPeriod: 'LHC22a',
+            },
+            {
+                runNumber: 56,
+                runQuality: RunQualities.GOOD,
+                definition: RunDefinition.Physics,
+                lhcPeriod: 'LHC22a',
+            },
+        ]);
+
+        fs.unlinkSync(path.resolve(downloadPath, targetFileName));
+    });
 };

test/utilities/waitForDownload.js

@@ -14,10 +14,12 @@
 /**
  * Create promise which is resolved when last initiated download is completed and rejected when canceled
  * @param {CDPSession} session puppetear CDP session
+ * @param {object} options options altering behaviour
+ * @param {number} [options.timeout = 5000] timeout (ms) to reject if not downloaded
  * @return {Promise} promise
  * !!! Downloading requires to set 'Browser.setDownloadBehavior' behaviour on the given CDP session
  */
-async function waitForDownload(session) {
+async function waitForDownload(session, { timeout = 5000 } = {}) {
     return new Promise((resolve, reject) => {
         session.on('Browser.downloadProgress', (event) => {
             if (event.state === 'completed') {
@@ -26,6 +28,7 @@ async function waitForDownload(session) {
                 reject('download canceled');
             }
         });
+        setTimeout(() => reject('Download timeout after ${timeout}'), timeout);
     });
 }