add count

Author: xsalonx

lib/database/repositories/QcFlagRepository.js

@@ -117,8 +117,9 @@ class QcFlagRepository extends Repository {
                     COUNT(DISTINCT qcf.id) = COUNT( DISTINCT gaqd.detector_id),
                     qc_flag_block_significance(qcft.bad, qcft.monte_carlo_reproducible),
                     NULL) AS significance,
-                GROUP_CONCAT( DISTINCT qcfv.flag_id ) AS verified_flags_list,
-                GROUP_CONCAT( DISTINCT qcfep.flag_id ) AS flags_list
+                GROUP_CONCAT( DISTINCT qcfv.flag_id )                     AS verified_flags_list,
+                GROUP_CONCAT( DISTINCT qcfep.flag_id )                    AS flags_list,
+                COUNT(DISTINCT gaqd.detector_id) - COUNT(DISTINCT qcf.id) AS undefined_quality_periods_count,
 
             FROM gaq_periods
 
@@ -152,7 +153,8 @@ class QcFlagRepository extends Repository {
                     qc_flag_block_significance_coverage(gaq.significance, coverage_ratio, 'mcr')  AS mcr_coverage,
                     qc_flag_block_significance_coverage(gaq.significance, coverage_ratio, 'good') AS good_coverage,
                     GROUP_CONCAT(verified_flags_list)                                             AS verified_flags_list,
-                    GROUP_CONCAT(flags_list)                                                      AS flags_list
+                    GROUP_CONCAT(flags_list)                                                      AS flags_list,
+                    SUM(undefined_quality_periods_count)                                          AS undefined_quality_periods_count
 
                 FROM (${blockAggregationQuery}) AS gaq
                 GROUP BY gaq.data_pass_id, gaq.run_number;
@@ -166,6 +168,7 @@ class QcFlagRepository extends Repository {
                 good_coverage,
                 flags_list,
                 verifiedd_flags_list,
+                undefined_quality_periods_count,
             }) => [
                 run_number,
                 {
@@ -174,6 +177,7 @@ class QcFlagRepository extends Repository {
                     goodCoverage: parseFloat(good_coverage ?? '0'),
                     flagsIds: [...new Set(flags_list?.split(','))],
                     verifiedFlagsIds: [...new Set(verifiedd_flags_list?.split(','))],
+                    undefinedQualityPeriodsCount: undefined_quality_periods_count,
                 },
             ],
         );

lib/public/views/Runs/RunPerDataPass/RunsPerDataPassOverviewPage.js

@@ -187,10 +187,11 @@ export const RunsPerDataPassOverviewPage = ({
                         format: (_, { runNumber }) => {
                             const runGaqSummary = gaqSummary[runNumber];
                             const FULL_COVERAGE = 1;
+                            const coverageEpsilon = 1e-6;
                             const totalCoverage = (runGaqSummary?.badEffectiveRunCoverage ?? 0) +
                                 (runGaqSummary?.explicitlyNotBadEffectiveRunCoverage ?? 0);
 
-                            const gaqDisplay = totalCoverage == FULL_COVERAGE
+                            const gaqDisplay = totalCoverage >= FULL_COVERAGE - coverageEpsilon
                                 ? getQcSummaryDisplay(runGaqSummary)
                                 : h('button.btn.btn-primary.w-100', 'GAQ');
 

lib/server/services/qualityControlFlag/GaqService.js

@@ -57,6 +57,7 @@ class GaqService {
                 goodCoverage,
                 flagsIds,
                 verifiedFlagsIds,
+                undefinedQualityPeriodsCount,
             },
         ]) => [
             runNumber,
@@ -65,6 +66,7 @@ class GaqService {
                 [QcSummarProperties.explicitlyNotBadEffectiveRunCoverage]: goodCoverage + (mcReproducibleAsNotBad ? mcReproducibleCoverage : 0),
                 [QcSummarProperties.mcReproducible]: mcReproducibleCoverage > 0,
                 [QcSummarProperties.missingVerificationsCount]: flagsIds.length - verifiedFlagsIds.length,
+                undefinedQualityPeriodsCount,
             },
         ]);