chore: switch url and notify arguments

NarrowsProjects · NarrowsProjects · commit 5abae211ad01 · 2026-06-17T12:56:51.000+02:00
diff --git a/lib/public/components/Filters/common/FilteringModel.js b/lib/public/components/Filters/common/FilteringModel.js
@@ -168,7 +168,7 @@ export class FilteringModel extends Observable {
      * @param {string|null} [url=null] the url that is to be parsed into active filters
      * @returns {undefined}
      */
-    setFilterFromURL(url = null, notify = false) {
+    setFilterFromURL(notify = false, url = null) {
         const params = this._computeParameters(url);
         const { page, filter } = params;
 
diff --git a/lib/public/components/Filters/common/filtersPanelPopover.js b/lib/public/components/Filters/common/filtersPanelPopover.js
@@ -161,7 +161,7 @@ const pasteButtonOption = (model) => {
     return h('button.btn.btn-primary', {
         onclick: async () => {
             const url = await navigator.clipboard.readText();
-            filteringModel.setFilterFromURL(url, true);
+            filteringModel.setFilterFromURL(true, url);
         },
         disabled: !clipboardSupported,
         id: 'paste-filter',
diff --git a/lib/public/views/DataPasses/DataPassesOverviewModel.js b/lib/public/views/DataPasses/DataPassesOverviewModel.js
@@ -61,7 +61,7 @@ export class DataPassesOverviewModel extends OverviewPageModel {
      * @param {boolean} notify if the FilteringModel should notify it's observers after finishing setting the filters
      */
     setFilterFromURL(notify) {
-        this._filteringModel.setFilterFromURL(null, notify);
+        this._filteringModel.setFilterFromURL(notify);
     }
 
     /**
diff --git a/lib/public/views/Environments/Overview/EnvironmentOverviewModel.js b/lib/public/views/Environments/Overview/EnvironmentOverviewModel.js
@@ -76,7 +76,7 @@ export class EnvironmentOverviewModel extends OverviewPageModel {
      * @param {boolean} notify if the FilteringModel should notify it's observers after finishing setting the filters
      */
     setFilterFromURL(notify) {
-        this._filteringModel.setFilterFromURL(null, notify);
+        this._filteringModel.setFilterFromURL(notify);
     }
 
     /**
diff --git a/lib/public/views/LhcFills/Overview/LhcFillsOverviewModel.js b/lib/public/views/LhcFills/Overview/LhcFillsOverviewModel.js
@@ -80,7 +80,7 @@ export class LhcFillsOverviewModel extends OverviewPageModel {
      * @param {boolean} notify if the FilteringModel should notify it's observers after finishing setting the filters
      */
     setFilterFromURL(notify) {
-        this._filteringModel.setFilterFromURL(null, notify);
+        this._filteringModel.setFilterFromURL(notify);
     }
 
     /**
diff --git a/lib/public/views/Logs/Overview/LogsOverviewModel.js b/lib/public/views/Logs/Overview/LogsOverviewModel.js
@@ -86,7 +86,7 @@ export class LogsOverviewModel extends Observable {
      * @param {boolean} notify if the FilteringModel should notify it's observers after finishing setting the filters
      */
     setFilterFromURL(notify) {
-        this._filteringModel.setFilterFromURL(null, notify);
+        this._filteringModel.setFilterFromURL(notify);
     }
 
     /**
diff --git a/lib/public/views/QcFlagTypes/Overview/QcFlagTypesOverviewModel.js b/lib/public/views/QcFlagTypes/Overview/QcFlagTypesOverviewModel.js
@@ -61,7 +61,7 @@ export class QcFlagTypesOverviewModel extends OverviewPageModel {
      * @param {boolean} notify if the FilteringModel should notify it's observers after finishing setting the filters
      */
     setFilterFromURL(notify) {
-        this._filteringModel.setFilterFromURL(null, notify);
+        this._filteringModel.setFilterFromURL(notify);
     }
 
     /**
diff --git a/lib/public/views/Runs/Overview/RunsOverviewModel.js b/lib/public/views/Runs/Overview/RunsOverviewModel.js
@@ -168,7 +168,7 @@ export class RunsOverviewModel extends OverviewPageModel {
      * @param {boolean} notify if the FilteringModel should notify it's observers after finishing setting the filters
      */
     setFilterFromURL(notify) {
-        this._filteringModel.setFilterFromURL(null, notify);
+        this._filteringModel.setFilterFromURL(notify);
     }
 
     /**
diff --git a/lib/public/views/SimulationPasses/AnchoredOverview/AnchoredSimulationPassesOverviewModel.js b/lib/public/views/SimulationPasses/AnchoredOverview/AnchoredSimulationPassesOverviewModel.js
@@ -48,7 +48,7 @@ export class AnchoredSimulationPassesOverviewModel extends OverviewPageModel {
      * @param {boolean} notify if the FilteringModel should notify it's observers after finishing setting the filters
      */
     setFilterFromURL(notify) {
-        this._filteringModel.setFilterFromURL(null, notify);
+        this._filteringModel.setFilterFromURL(notify);
     }
 
     /**
diff --git a/lib/public/views/SimulationPasses/PerLhcPeriodOverview/SimulationPassesPerLhcPeriodOverviewModel.js b/lib/public/views/SimulationPasses/PerLhcPeriodOverview/SimulationPassesPerLhcPeriodOverviewModel.js
@@ -64,7 +64,7 @@ export class SimulationPassesPerLhcPeriodOverviewModel extends OverviewPageModel
      * @param {boolean} notify if the FilteringModel should notify it's observers after finishing setting the filters
      */
     setFilterFromURL(notify) {
-        this._filteringModel.setFilterFromURL(null, notify);
+        this._filteringModel.setFilterFromURL(notify);
     }
 
     /**
diff --git a/lib/public/views/lhcPeriods/Overview/LhcPeriodsOverviewModel.js b/lib/public/views/lhcPeriods/Overview/LhcPeriodsOverviewModel.js
@@ -61,7 +61,7 @@ export class LhcPeriodsOverviewModel extends OverviewPageModel {
      * @param {boolean} notify if the FilteringModel should notify it's observers after finishing setting the filters
      */
     setFilterFromURL(notify) {
-        this._filteringModel.setFilterFromURL(null, notify);
+        this._filteringModel.setFilterFromURL(notify);
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -61,7 +61,7 @@ export class DataPassesOverviewModel extends OverviewPageModel {`
`61`	`61`	`* @param {boolean} notify if the FilteringModel should notify it's observers after finishing setting the filters`
`62`	`62`	`*/`
`63`	`63`	`setFilterFromURL(notify) {`
`64`		`- this._filteringModel.setFilterFromURL(null, notify);`
	`64`	`+ this._filteringModel.setFilterFromURL(notify);`
`65`	`65`	`}`
`66`	`66`
`67`	`67`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -76,7 +76,7 @@ export class EnvironmentOverviewModel extends OverviewPageModel {`
`76`	`76`	`* @param {boolean} notify if the FilteringModel should notify it's observers after finishing setting the filters`
`77`	`77`	`*/`
`78`	`78`	`setFilterFromURL(notify) {`
`79`		`- this._filteringModel.setFilterFromURL(null, notify);`
	`79`	`+ this._filteringModel.setFilterFromURL(notify);`
`80`	`80`	`}`
`81`	`81`
`82`	`82`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -80,7 +80,7 @@ export class LhcFillsOverviewModel extends OverviewPageModel {`
`80`	`80`	`* @param {boolean} notify if the FilteringModel should notify it's observers after finishing setting the filters`
`81`	`81`	`*/`
`82`	`82`	`setFilterFromURL(notify) {`
`83`		`- this._filteringModel.setFilterFromURL(null, notify);`
	`83`	`+ this._filteringModel.setFilterFromURL(notify);`
`84`	`84`	`}`
`85`	`85`
`86`	`86`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -86,7 +86,7 @@ export class LogsOverviewModel extends Observable {`
`86`	`86`	`* @param {boolean} notify if the FilteringModel should notify it's observers after finishing setting the filters`
`87`	`87`	`*/`
`88`	`88`	`setFilterFromURL(notify) {`
`89`		`- this._filteringModel.setFilterFromURL(null, notify);`
	`89`	`+ this._filteringModel.setFilterFromURL(notify);`
`90`	`90`	`}`
`91`	`91`
`92`	`92`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -61,7 +61,7 @@ export class QcFlagTypesOverviewModel extends OverviewPageModel {`
`61`	`61`	`* @param {boolean} notify if the FilteringModel should notify it's observers after finishing setting the filters`
`62`	`62`	`*/`
`63`	`63`	`setFilterFromURL(notify) {`
`64`		`- this._filteringModel.setFilterFromURL(null, notify);`
	`64`	`+ this._filteringModel.setFilterFromURL(notify);`
`65`	`65`	`}`
`66`	`66`
`67`	`67`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -168,7 +168,7 @@ export class RunsOverviewModel extends OverviewPageModel {`
`168`	`168`	`* @param {boolean} notify if the FilteringModel should notify it's observers after finishing setting the filters`
`169`	`169`	`*/`
`170`	`170`	`setFilterFromURL(notify) {`
`171`		`- this._filteringModel.setFilterFromURL(null, notify);`
	`171`	`+ this._filteringModel.setFilterFromURL(notify);`
`172`	`172`	`}`
`173`	`173`
`174`	`174`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@ export class AnchoredSimulationPassesOverviewModel extends OverviewPageModel {`
`48`	`48`	`* @param {boolean} notify if the FilteringModel should notify it's observers after finishing setting the filters`
`49`	`49`	`*/`
`50`	`50`	`setFilterFromURL(notify) {`
`51`		`- this._filteringModel.setFilterFromURL(null, notify);`
	`51`	`+ this._filteringModel.setFilterFromURL(notify);`
`52`	`52`	`}`
`53`	`53`
`54`	`54`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,7 @@ export class SimulationPassesPerLhcPeriodOverviewModel extends OverviewPageModel`
`64`	`64`	`* @param {boolean} notify if the FilteringModel should notify it's observers after finishing setting the filters`
`65`	`65`	`*/`
`66`	`66`	`setFilterFromURL(notify) {`
`67`		`- this._filteringModel.setFilterFromURL(null, notify);`
	`67`	`+ this._filteringModel.setFilterFromURL(notify);`
`68`	`68`	`}`
`69`	`69`
`70`	`70`	`/**`