Skip to content

Commit 5cccea7

Browse files
committed
rm visual changes obervable
1 parent 1b0fcda commit 5cccea7

2 files changed

Lines changed: 2 additions & 16 deletions

File tree

lib/public/models/DataExportModel.js

Lines changed: 2 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,6 @@ export class DataExportModel extends Observable {
4949

5050
this._selectedExportType = DataExportTypes.JSON;
5151

52-
this._visualChange$ = new Observable();
53-
5452
this._exportName = 'data';
5553

5654
this._dataExportConfiguration = dataExportConfiguration;
@@ -85,7 +83,7 @@ export class DataExportModel extends Observable {
8583
*/
8684
setTotalExistingItemsCount(totalExistingItemsCount) {
8785
this._totalExistingItemsCount = totalExistingItemsCount;
88-
this._visualChange$.notify();
86+
this.notify();
8987
}
9088

9189
/**
@@ -102,7 +100,7 @@ export class DataExportModel extends Observable {
102100
*/
103101
setDisabled(disabled) {
104102
this._disabled = disabled;
105-
this._visualChange$.notify();
103+
this.notify();
106104
}
107105

108106
/**
@@ -129,15 +127,6 @@ export class DataExportModel extends Observable {
129127
return this._items$.getCurrent();
130128
}
131129

132-
/**
133-
* Observable notified when the export configuration visually changes
134-
*
135-
* @return {Observable} the visual change observable
136-
*/
137-
get visualChange$() {
138-
return this._visualChange$;
139-
}
140-
141130
/**
142131
* Get export type selected by the user
143132
*
@@ -156,7 +145,6 @@ export class DataExportModel extends Observable {
156145
setSelectedExportType(exportType) {
157146
this._selectedExportType = exportType;
158147
this.notify();
159-
this._visualChange$.notify();
160148
}
161149

162150
/**
@@ -177,7 +165,6 @@ export class DataExportModel extends Observable {
177165
setSelectedFields(selectedOptions) {
178166
this._selectedFields = Array.from(selectedOptions).map(({ value }) => value);
179167
this.notify();
180-
this._visualChange$.notify();
181168
}
182169

183170
/**

lib/public/views/Runs/Overview/RunsOverviewModel.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,6 @@ export class RunsOverviewModel extends OverviewPageModel {
9999

100100
this._exportModel = new DataExportModel(this._allItems$, dataExportConfiguration, () => this.loadAll());
101101
this._exportModel.bubbleTo(this);
102-
this._exportModel.visualChange$.bubbleTo(this);
103102
this._item$.observe(() => {
104103
this._exportModel.setDisabled(!this.hasAnyData());
105104
this._exportModel.setTotalExistingItemsCount(this._pagination.itemsCount);

0 commit comments

Comments
 (0)