update getQCdetector

Author: xsalonx

lib/domain/enums/DetectorTypes.js

@@ -28,8 +28,11 @@ const DETECTOR_TYPES = Object.values(DetectorType);
  */
 const DATA_TAKING_DETECTOR_TYPES = [DetectorType.PHYSICAL, DetectorType.VIRTUAL];
 
+const QC_DETECTOR_TYPES = [DetectorType.PHYSICAL, DetectorType.QC_ONLY, DetectorType.AOT_EVENT, DetectorType.AOT_GLO, DetectorType.MUON_GLO];
+
 module.exports = {
     DetectorType,
     DETECTOR_TYPES,
     DATA_TAKING_DETECTOR_TYPES,
+    QC_DETECTOR_TYPES,
 };

lib/server/services/detector/getQcDetectorOrFail.js

@@ -15,7 +15,7 @@ const { BadParameterError } = require('../../errors/BadParameterError.js');
 const { DetectorRepository } = require('../../../database/repositories/index.js');
 const { Op } = require('sequelize');
 const { NotFoundError } = require('../../errors/NotFoundError.js');
-const { DetectorType } = require('../../../domain/enums/DetectorTypes.js');
+const { QC_DETECTOR_TYPES } = require('../../../domain/enums/DetectorTypes.js');
 
 /**
  * Find and return a QC (PHYSICAL or QC_ONLY) detector identified by its name or id and throw if it does not exists
@@ -37,7 +37,7 @@ exports.getQcDetectorOrFail = async ({ detectorId, detectorName }) => {
         where: {
             [Op.and]: [
                 criteria,
-                { type: { [Op.in]: [DetectorType.PHYSICAL, DetectorType.QC_ONLY] } },
+                { type: { [Op.in]: QC_DETECTOR_TYPES } },
             ],
         },
     });
@@ -46,7 +46,7 @@ exports.getQcDetectorOrFail = async ({ detectorId, detectorName }) => {
         const criteriaExpression = detectorId !== undefined && detectorId !== null
             ? `id (${detectorId})`
             : `name (${detectorName})`;
-        throw new NotFoundError(`Physical detector with this ${criteriaExpression} could not be found`);
+        throw new NotFoundError(`QC detector with this ${criteriaExpression} could not be found`);
     }
     return detector;
 };