Skip to content

Commit 685dd38

Browse files
author
Guust
committed
remove _raw as from authorfilterModel, as it serves no purpose
1 parent 18ce4dc commit 685dd38

1 file changed

Lines changed: 3 additions & 14 deletions

File tree

lib/public/components/Filters/LogsFilter/author/AuthorFilterModel.js

Lines changed: 3 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@ export class AuthorFilterModel extends RawTextFilterModel {
2424
*/
2525
constructor() {
2626
super();
27-
this._raw = '';
2827
}
2928

3029
/**
@@ -33,7 +32,7 @@ export class AuthorFilterModel extends RawTextFilterModel {
3332
* @return {boolean} true if '!Anonymous' is included in the raw filter string, false otherwise.
3433
*/
3534
isAnonymousExcluded() {
36-
return this._raw.includes('!Anonymous');
35+
return this._value.includes('!Anonymous');
3736
}
3837

3938
/**
@@ -43,23 +42,13 @@ export class AuthorFilterModel extends RawTextFilterModel {
4342
*/
4443
toggleAnonymousFilter() {
4544
if (this.isAnonymousExcluded()) {
46-
this._raw = this._raw.split(',')
45+
this._value = this._value.split(',')
4746
.filter((author) => author.trim() !== '!Anonymous')
4847
.join(',');
4948
} else {
50-
this._raw += super.isEmpty ? '!Anonymous' : ', !Anonymous';
49+
this._value += super.isEmpty ? '!Anonymous' : ', !Anonymous';
5150
}
5251

53-
this._value = this._raw.trim();
5452
this.notify();
5553
}
56-
57-
/**
58-
* @inheritdoc
59-
* @override
60-
*/
61-
reset() {
62-
super.reset();
63-
this._raw = '';
64-
}
6554
}

0 commit comments

Comments
 (0)