feat: update radioFilterModel with defaultIsEmpty argument

Author: NarrowsProjects

lib/public/components/Filters/common/RadioButtonFilterModel.js

@@ -22,13 +22,24 @@ export class RadioButtonFilterModel extends SelectionModel {
      *
      * @param {SelectionOption[]} [availableOptions] the list of possible operators
      * @param {function} [setDefault] function that selects the default from the list of available options. Selects first entry by default
+     * @param {boolean} [defaultIsEmpty] if true, the default selection will be treated as empty
      */
-    constructor(availableOptions, setDefault = (options) => [options[0]]) {
+    constructor(availableOptions, setDefault = (options) => [options[0]], defaultIsEmpty = true) {
         super({
             availableOptions,
             defaultSelection: setDefault(availableOptions),
             multiple: false,
             allowEmpty: false,
         });
+
+        this._defaultIsEmpty = defaultIsEmpty;
+    }
+
+    get isEmpty() {
+        if (this._defaultIsEmpty) {
+            return this.hasOnlyDefaultSelection();
+        }        
+
+        return false;
     }
 }

lib/public/components/Filters/common/filters/ToggleFilterModel.js

@@ -19,17 +19,17 @@ export class ToggleFilterModel extends SelectionModel {
     /**
      * Constructor
      * @param {boolean} toggledByDefault If the filter should be toggled by default
-     * @param {boolean} falseIsEmpty if true, will treat false as empty.
+     * @param {boolean} untoggledIsEmpty if true, will treat the untoggled state (false) as empty.
      */
-    constructor(toggledByDefault = false, falseIsEmpty = false) {
+    constructor(toggledByDefault = false, untoggledIsEmpty = false) {
         super({
             availableOptions: [{ value: true }, { value: false }],
             defaultSelection: [{ value: toggledByDefault }],
             multiple: false,
             allowEmpty: false,
         });
 
-        this._falseIsEmpty = falseIsEmpty;
+        this._untoggledIsEmpty = untoggledIsEmpty;
     }
 
     /**
@@ -52,18 +52,15 @@ export class ToggleFilterModel extends SelectionModel {
 
     /**
      * Determines whether the current value should be considered empty.
-     *
-     * By default (`falseIsEmpty = false`), this model never treats its value
-     * as empty—both `true` and `false` are considered valid selections.
-     *
-     * If `falseIsEmpty = true`, then a value of `false` is treated as empty.
+     * When this._falseIsEmpty is set to 'true', then a 'false' selection (untoggled) 
+     * will be treated as an empty filter
      *
      * @return {boolean} `true` if the current value is considered empty,
      * otherwise `false`.
      */
     get isEmpty() {
-        if (this._falseIsEmpty) {
-            return this.current === false;
+        if (this._untoggledIsEmpty) {
+            return this.isToggled === false;
         }
 
         return false;