Fix [O2B-1291] Remove unnecessary space between runs table and pagination controller (#1938)

* a

* add CSS

* abstraction

* tmp tmp tmp

* WIP step 1

* a

* works

* works

* cleanup

* cleanup

* cleanup

* cleanup

* fix verticall scroll

* fix per simulation pass

* fix pe rLHC periods

* linter

* linter

* linter

* fix fng puppeteer

* last fix

* typo

* cleanup

* fix

* Revert "fix"

This reverts commit 35a28ed.

* fixes

* typo

Author: xsalonx

lib/public/components/common/table/table.js

@@ -92,6 +92,8 @@ const parseColumnsConfiguration = (columns, currentProfile) => {
  * @property {boolean} verticallScrollEnabled if true, enable vertical (table internal) scroll in case of overflow,
  * whole page vertical scroll otherwise. Note that for this option to work,
  * all predecesors of the node returned by this function must have display property column-flex and height: 100%
+ * @property {boolean} singleWrapper have effect only when some scroll is enabled.
+ * If true all divs wrapping table element are merged to single on.
  */
 
 /**
@@ -134,6 +136,7 @@ export const table = (
         horizontalScrollEnabled = false,
         freezeFirstColumn = false,
         verticalScrollEnabled = false,
+        singleWrapper = false,
     } = tableConfiguration || {};
     const { idKey, displayedColumns } = parseColumnsConfiguration(columns, currentProfile);
 
@@ -147,12 +150,14 @@ export const table = (
     }
 
     const scrollEnabled = horizontalScrollEnabled || verticalScrollEnabled;
-    const wrapperClassesExpression = scrollEnabled ? '.sticky-table-wrapper.scroll-auto' : '';
-
     const optionalTableClassesExpression = freezeFirstColumn && horizontalScrollEnabled ? '.freeze-first-column' : '';
 
-    const wrappedTableNode = h(
-        wrapperClassesExpression,
+    const firstLevelWrapperClasses =
+        (verticalScrollEnabled ? '.sticky-table-wrapper' : '') +
+        (singleWrapper && scrollEnabled ? '.scroll-auto' : '');
+
+    let wrappedTableNode = h(
+        firstLevelWrapperClasses,
         h(
             `table.table.table-hover.shadow-level1${optionalTableClassesExpression}`,
             {
@@ -168,6 +173,11 @@ export const table = (
             ],
         ),
     );
+
+    if (scrollEnabled && !singleWrapper) {
+        wrappedTableNode = h('.scroll-auto', wrappedTableNode);
+    }
+
     return scrollEnabled && !verticalScrollEnabled
         ? h('', wrappedTableNode) // Disable y-scroll
         : wrappedTableNode;

lib/public/views/Runs/RunPerPeriod/RunsPerLhcPeriodOverviewPage.js

@@ -98,6 +98,7 @@ export const RunsPerLhcPeriodOverviewPage = ({ runs: { perLhcPeriodOverviewModel
             {
                 profile: 'runsPerLhcPeriod',
                 ...displayOptions,
+                singleWrapper: true,
             },
             { sort: sortModel },
         );
@@ -130,7 +131,7 @@ export const RunsPerLhcPeriodOverviewPage = ({ runs: { perLhcPeriodOverviewModel
                     )),
             },
             {
-                panelClass: ['p2', 'scroll-auto'],
+                panelClass: ['scroll-auto'],
             },
         ),
         paginationComponent(perLhcPeriodOverviewModel.pagination),