cleanup

Author: xsalonx

lib/public/components/Filters/common/FilteringModel.js

@@ -123,6 +123,8 @@ export class FilteringModel extends Observable {
     /**
      * Add new filter
      *
+     * NOTE that the method has no effect if called more than once for the same key
+     *
      * @param {string} key key of a new filter
      * @param {FilterModel} filter the new filter
      */

lib/public/views/Runs/RunPerDataPass/RunsPerDataPassOverviewModel.js

@@ -24,7 +24,7 @@ import { jsonFetch } from '../../../utilities/fetch/jsonFetch.js';
 import { mergeRemoteData } from '../../../utilities/mergeRemoteData.js';
 import { DetectorType } from '../../../domain/enums/DetectorTypes.js';
 
-const CPASS_ALL_REGEX = /cpass\d+/;
+const ALL_CPASS_PRODUCTIONS_REGEX = /cpass\d+/;
 
 /**
  * Runs Per Data Pass overview model
@@ -43,7 +43,7 @@ export class RunsPerDataPassOverviewModel extends FixedPdpBeamTypeRunsOverviewMo
             .builder()
             .sources([detectorsProvider.qc$, this._dataPass$])
             .apply((remoteDataList) => mergeRemoteData(remoteDataList)
-                .apply({ Success: ([detectors, dataPass]) => CPASS_ALL_REGEX.test(dataPass.name)
+                .apply({ Success: ([detectors, dataPass]) => ALL_CPASS_PRODUCTIONS_REGEX.test(dataPass.name)
                     ? detectors.filter(({ type }) => type !== DetectorType.AOT_GLO)
                     : detectors,
                 }))