Fix typos in Dass Pass Service (#1403)

Author: xsalonx

lib/server/services/dataPasses/DataPassService.js

@@ -53,7 +53,7 @@ class DataPassService {
         } else if (name) {
             queryBuilder.where('name').is(name);
         } else {
-            throw new BadParameterError('Can not find without LHC Period id or name');
+            throw new BadParameterError('Can not find without Data Pass id or name');
         }
 
         queryBuilder.includeAttribute({
@@ -72,12 +72,12 @@ class DataPassService {
      * @return {Promise<DataPass[]>} the dats pass found
      */
     async getOneOrFail({ id, name }) {
-        const lhcPeriodStatistics = await this.getByIdentifier({ id, name });
-        if (!lhcPeriodStatistics) {
+        const dataPass = await this.getByIdentifier({ id, name });
+        if (!dataPass) {
             const criteriaExpression = id !== undefined && id !== null ? `id (${id})` : `name (${name})`;
             throw new NotFoundError(`Data Pass with this ${criteriaExpression} could not be found`);
         }
-        return lhcPeriodStatistics;
+        return dataPass;
     }
 
     /**

test/lib/server/services/dataPasses/DataPassesService.test.js

@@ -51,13 +51,13 @@ module.exports = () => {
     before(resetDatabaseContent);
 
     it('should succesfully get by id', async () => {
-        const lhcPeriod = await dataPassService.getByIdentifier({ id: 1 });
-        expect(lhcPeriod).to.be.eql(LHC22b_apass1);
+        const dataPass = await dataPassService.getByIdentifier({ id: 1 });
+        expect(dataPass).to.be.eql(LHC22b_apass1);
     });
 
     it('should succesfully get by name', async () => {
-        const lhcPeriod = await dataPassService.getByIdentifier({ name: 'LHC22a_apass1' });
-        expect(lhcPeriod).to.be.eql(LHC22a_apass1);
+        const dataPass = await dataPassService.getByIdentifier({ name: 'LHC22a_apass1' });
+        expect(dataPass).to.be.eql(LHC22a_apass1);
     });
 
     it('should succesfully get all data', async () => {