Skip to content

Commit b42a43c

Browse files
author
NarrowsProjects
committed
chore: remove all mentions of selectionFilterModel and replace it with SelectionModel
1 parent b5d8fc4 commit b42a43c

11 files changed

Lines changed: 18 additions & 89 deletions

File tree

lib/public/components/Filters/LhcFillsFilter/BeamTypeFilterModel.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,12 +12,12 @@
1212
*/
1313

1414
import { beamTypesProvider } from '../../../services/beamTypes/beamTypesProvider.js';
15-
import { SelectionFilterModel } from '../common/filters/SelectionFilterModel.js';
15+
import { SelectionModel } from '../../common/selection/SelectionModel.js';
1616

1717
/**
1818
* Beam type filter model
1919
*/
20-
export class BeamTypeFilterModel extends SelectionFilterModel {
20+
export class BeamTypeFilterModel extends SelectionModel {
2121
/**
2222
* Constructor
2323
*/
@@ -28,7 +28,7 @@ export class BeamTypeFilterModel extends SelectionFilterModel {
2828
beamTypesProvider.items$.getCurrent().apply({
2929
Success: (types) => {
3030
const beamTypes = types.map((type) => ({ value: type.beam_type }));
31-
this._selectionModel.setAvailableOptions(beamTypes);
31+
this.setAvailableOptions(beamTypes);
3232
},
3333
});
3434
});

lib/public/components/Filters/LhcFillsFilter/beamTypeFilter.js

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,8 +19,4 @@ import { checkboxes } from '../common/filters/checkboxFilter.js';
1919
* @param {BeamTypeFilterModel} beamTypeFilterModel beamTypeFilterModel
2020
* @return {Component} the filter
2121
*/
22-
export const beamTypeFilter = (beamTypeFilterModel) =>
23-
checkboxes(
24-
beamTypeFilterModel.selectionModel,
25-
{ selector: 'beam-types' },
26-
);
22+
export const beamTypeFilter = (beamTypeFilterModel) => checkboxes(beamTypeFilterModel, { selector: 'beam-types' });

lib/public/components/Filters/RunsFilter/RunDefinitionFilterModel.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
11
import { RUN_DEFINITIONS, RunDefinition } from '../../../domain/enums/RunDefinition.js';
2-
import { SelectionFilterModel } from '../common/filters/SelectionFilterModel.js';
2+
import { SelectionModel } from '../../common/selection/SelectionModel.js';
33

44
/**
55
* Run definition filter model
66
*/
7-
export class RunDefinitionFilterModel extends SelectionFilterModel {
7+
export class RunDefinitionFilterModel extends SelectionModel {
88
/**
99
* Constructor
1010
*/
@@ -18,7 +18,7 @@ export class RunDefinitionFilterModel extends SelectionFilterModel {
1818
* @return {boolean} true if filter is physics only
1919
*/
2020
isPhysicsOnly() {
21-
const selectedOptions = this._selectionModel.selected;
21+
const selectedOptions = this.selected;
2222
return selectedOptions.length === 1 && selectedOptions[0] === RunDefinition.Physics;
2323
}
2424

@@ -29,8 +29,8 @@ export class RunDefinitionFilterModel extends SelectionFilterModel {
2929
*/
3030
setPhysicsOnly() {
3131
if (!this.isPhysicsOnly()) {
32-
this._selectionModel.selectedOptions = [];
33-
this._selectionModel.select(RunDefinition.Physics);
32+
this.selectedOptions = [];
33+
this.select(RunDefinition.Physics);
3434
this.notify();
3535
}
3636
}

lib/public/components/Filters/RunsFilter/runDefinitionFilter.js

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,4 @@ import { checkboxes } from '../common/filters/checkboxFilter.js';
1919
* @param {RunDefinitionFilterModel} runDefinitionFilterModel run definition filter model
2020
* @return {Component} the filter
2121
*/
22-
export const runDefinitionFilter = (runDefinitionFilterModel) => checkboxes(
23-
runDefinitionFilterModel.selectionModel,
24-
{ selector: 'run-definition' },
25-
);
22+
export const runDefinitionFilter = (runDefinitionFilterModel) => checkboxes(runDefinitionFilterModel, { selector: 'run-definition' });

lib/public/components/Filters/common/filters/SelectionFilterModel.js

Lines changed: 0 additions & 63 deletions
This file was deleted.

lib/public/views/DataPasses/ActiveColumns/dataPassesActiveColumns.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ export const dataPassesActiveColumns = {
102102

103103
nonPhysicsProductions: {
104104
name: 'Include nonphysics productions',
105-
filter: (filteringModel) => checkboxes(filteringModel.get('include[byName]').selectionModel),
105+
filter: (filteringModel) => checkboxes(filteringModel.get('include[byName]')),
106106
visible: false,
107107
},
108108
};

lib/public/views/DataPasses/DataPassesOverviewModel.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@
1010
* granted to it by virtue of its status as an Intergovernmental Organization
1111
* or submit itself to any jurisdiction.
1212
*/
13+
import { SelectionModel } from '../../components/common/selection/SelectionModel.js';
1314
import { FilteringModel } from '../../components/Filters/common/FilteringModel.js';
14-
import { SelectionFilterModel } from '../../components/Filters/common/filters/SelectionFilterModel.js';
1515
import { TextTokensFilterModel } from '../../components/Filters/common/filters/TextTokensFilterModel.js';
1616
import { NON_PHYSICS_PRODUCTIONS_NAMES_WORDS } from '../../domain/enums/NonPhysicsProductionsNamesWords.js';
1717
import { OverviewPageModel } from '../../models/OverviewModel.js';
@@ -31,7 +31,7 @@ export class DataPassesOverviewModel extends OverviewPageModel {
3131
router,
3232
{
3333
names: new TextTokensFilterModel(),
34-
'include[byName]': new SelectionFilterModel({
34+
'include[byName]': new SelectionModel({
3535
availableOptions: NON_PHYSICS_PRODUCTIONS_NAMES_WORDS.map((word) => ({ label: word.toUpperCase(), value: word })),
3636
}),
3737
},

lib/public/views/Environments/ActiveColumns/environmentsActiveColumns.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ export const environmentsActiveColumns = {
117117
* @param {EnvironmentOverviewModel} environmentOverviewModel the environment overview model
118118
* @return {Component} the filter component
119119
*/
120-
filter: (environmentOverviewModel) => checkboxes(environmentOverviewModel.filteringModel.get('currentStatus').selectionModel),
120+
filter: (environmentOverviewModel) => checkboxes(environmentOverviewModel.filteringModel.get('currentStatus')),
121121
},
122122
historyItems: {
123123
name: h('.flex-row.g2.items-center', ['Status History', infoTooltip(environmentStatusHistoryLegendComponent())]),

lib/public/views/Environments/Overview/EnvironmentOverviewModel.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,11 @@ import { buildUrl } from '/js/src/index.js';
1515
import { FilteringModel } from '../../../components/Filters/common/FilteringModel.js';
1616
import { OverviewPageModel } from '../../../models/OverviewModel.js';
1717
import { TimeRangeInputModel } from '../../../components/Filters/common/filters/TimeRangeInputModel.js';
18-
import { SelectionFilterModel } from '../../../components/Filters/common/filters/SelectionFilterModel.js';
1918
import { RawTextFilterModel } from '../../../components/Filters/common/filters/RawTextFilterModel.js';
2019
import { debounce } from '../../../utilities/debounce.js';
2120
import { coloredEnvironmentStatusComponent } from '../ColoredEnvironmentStatusComponent.js';
2221
import { StatusAcronym } from '../../../domain/enums/statusAcronym.mjs';
22+
import { SelectionModel } from '../../../components/common/selection/SelectionModel.js';
2323

2424
/**
2525
* Environment overview page model
@@ -39,7 +39,7 @@ export class EnvironmentOverviewModel extends OverviewPageModel {
3939
created: new TimeRangeInputModel(),
4040
runNumbers: new RawTextFilterModel(),
4141
statusHistory: new RawTextFilterModel(),
42-
currentStatus: new SelectionFilterModel({
42+
currentStatus: new SelectionModel({
4343
availableOptions: Object.keys(StatusAcronym).map((status) => ({
4444
value: status,
4545
label: coloredEnvironmentStatusComponent(status),

lib/public/views/Runs/ActiveColumns/runsActiveColumns.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -441,7 +441,7 @@ export const runsActiveColumns = {
441441
* @param {RunsOverviewModel} runsOverviewModel the runs overview model
442442
* @return {Component} the run quality filter component
443443
*/
444-
filter: (runsOverviewModel) => checkboxes(runsOverviewModel.filteringModel.get('runQualities').selectionModel),
444+
filter: (runsOverviewModel) => checkboxes(runsOverviewModel.filteringModel.get('runQualities')),
445445
},
446446
nDetectors: {
447447
name: 'DETs #',

0 commit comments

Comments
 (0)