[O2B-1534] Migrate log overview to use filtering model pattern (#2083)

* chore: remove redundant model assignment.

* chore: move all filters denoted as so to a filteringModel

* Make filterInputModel extend filterModel

* rename inputfilter to ParsedInputFilter

* implement authorfilter with ParsedInputFilterModel changes

* re-implement filter

* add tag-filters to the filtering object

* replace titleFilter and contentFilter with RawTextFilterModels

* make Authorfilter an implementation of RawTextFilterModel

* add runs filter to the filteringmodel

* add environments filter to the filteringmodel

* add lhcFills filter to the filteringmodel

* add created filter to the filteringmodel

* move the sort 'filter' to fetchlogs, since it doesn't actually filter anything

* change filter to rawTextFilter for title

* fix test by changing event type to 'change'

* fix content and author tests

* import openFilteringPanel and resetFilters

* fix createdAt filter test

* change event types to change

* fix isAnyFilterActive

* remove _raw as from authorfilterModel, as it serves no purpose

* chore: removed ParsedInputFilterModel

* chore: add toLowerCase to filterQueryParam computation

* [O2B-1530] Lhc fills add sb duration filter (#2080)

* Filtering by stableBeamsStart and stableBeamsEnd has been added to LHC Fills overview page
* lhcFills endpoint & DTO validation modified and testing added for the aforementioned changes
---------

Co-authored-by: GuustMetz <guust.metz@cern.ch>
Co-authored-by: Guust <metzguust@gmail.com>

* [O2B-1544] Fix pagination for filtered envs and add a test (#2096)

* Replaced the two-query pattern with a single queryBuilder in GetAllEnvironmentsUseCase. The previous approach was redundant following Sequelize performance improvements; furthermore, the original implementation's logic was flawed which resulted in the pagination bug.

* remove the combination operator from runs

* remove the combination operator from envirionments

* remove the combination operator from lhcFills

* make filter computation much more compact using filteringmodel.normalize

* add happy-flow tests for logs api

* fix usecase unit tests

* chore: provide the authorFilterMode directly to the component

* chore: alter rawTextFilter to accept a boolean parameter that determines if the reset function also notifies the observers

* chore: 1. revert previous change. 2. overwrite reset in author model and call notify there

* chore: remove true from the reset function call

* chore: add placeholders for the new rawTextFilters

* improve reset readability

* check runnumber fill number and lhc period for existence rather than for length

* undo test comments

* chore rename reset to clear()

* make overview test more efficient with beforeEach

* test: remove unneeded OpenFilterPanel calls

* remove takescreenshot

* Remove unneeded javadoc params

* chore: change the with margins to roughly span the filters the entire filter popover

* test: add happy-flow rootOnly test

* test: add log sorting tests for runs and for envirionments

* reduce the width of the author filter component

* chore removed unneeded length checks from should successfully filter by rootOnly

* chore: remove the needless 'limit' part of the rootOnly logs test

* feat: create textInputFilter

* chore: replace runNumbersFilter and rawTextFileters with logsActiveColumns

* feat: add a width argument to textinputFIlter

* replace the rest of the rawTextFilters

* update tests to function with the new textInput components

* fix failing tests

* chore: delete fillNumbersFilter createdFilter, logs/environmentFilter, runs/environmentFilter and   schemeNameFilter

* undo incorrect return description of the author component jsdoc

Author: NarrowsProjects

lib/domain/dtos/GetAllLogsDto.js

@@ -17,32 +17,25 @@ const PaginationDto = require('./PaginationDto');
 const { CustomJoi } = require('./CustomJoi.js');
 const { TagsFilterDto } = require('./filters/TagsFilterDto.js');
 const { FromToFilterDto } = require('./filters/FromToFilterDto.js');
-const { EnvironmentsFilterDto } = require('./filters/EnvironmentsFilterDto');
 
-const RunFilterDto = Joi.object({
-    values: CustomJoi.stringArray().items(EntityIdDto).single().required(),
-    operation: Joi.string().valid('and', 'or').required(),
-});
-
-const LhcFillFilterDto = Joi.object({
-    values: CustomJoi.stringArray().items(EntityIdDto).single().required(),
-    operation: Joi.string().valid('and', 'or').required(),
-});
+const RunFilterDto = CustomJoi.stringArray().items(EntityIdDto).single();
+const EnvironmentsFilterDto = CustomJoi.stringArray().items(Joi.string()).single();
+const LhcFillFilterDto = CustomJoi.stringArray().items(EntityIdDto).single();
 
 const FilterDto = Joi.object({
     title: Joi.string().trim(),
     content: Joi.string().trim(),
     author: Joi.string().trim(),
     created: FromToFilterDto,
     tags: TagsFilterDto,
-    lhcFills: LhcFillFilterDto,
-    run: RunFilterDto,
+    fillNumbers: LhcFillFilterDto,
+    runNumbers: RunFilterDto,
     origin: Joi.string()
         .valid('human', 'process'),
     parentLog: EntityIdDto,
     rootLog: EntityIdDto,
     rootOnly: Joi.boolean(),
-    environments: EnvironmentsFilterDto,
+    environmentIds: EnvironmentsFilterDto,
 });
 
 const SortDto = Joi.object({

lib/domain/dtos/filters/EnvironmentsFilterDto.js

@@ -11,12 +11,12 @@
  * or submit itself to any jurisdiction.
  */
 
-import { FilterInputModel } from '../../common/filters/FilterInputModel.js';
+import { RawTextFilterModel } from '../../common/filters/RawTextFilterModel.js';
 
 /**
  * Model to handle the state of the Author Filter
  */
-export class AuthorFilterModel extends FilterInputModel {
+export class AuthorFilterModel extends RawTextFilterModel {
     /**
      * Constructor
      *
@@ -32,7 +32,7 @@ export class AuthorFilterModel extends FilterInputModel {
      * @return {boolean} true if '!Anonymous' is included in the raw filter string, false otherwise.
      */
     isAnonymousExcluded() {
-        return this._raw.includes('!Anonymous');
+        return this._value.includes('!Anonymous');
     }
 
     /**
@@ -42,28 +42,25 @@ export class AuthorFilterModel extends FilterInputModel {
      */
     toggleAnonymousFilter() {
         if (this.isAnonymousExcluded()) {
-            this._raw = this._raw.split(',')
+            this._value = this._value.split(',')
                 .filter((author) => author.trim() !== '!Anonymous')
                 .join(',');
         } else {
-            this._raw += super.isEmpty ? '!Anonymous' : ', !Anonymous';
+            this._value += super.isEmpty ? '!Anonymous' : ', !Anonymous';
         }
 
-        this._value = this.valueFromRaw(this._raw);
         this.notify();
     }
 
     /**
-     * Reset the filter to its default value and notify the observers.
+     * Reset the filter to its default value and notify the observers if the reset changed anything.
      *
      * @return {void}
      */
     clear() {
-        if (this.isEmpty) {
-            return;
+        if (!this.isEmpty) {
+            super.reset();
+            this.notify();
         }
-
-        super.reset();
-        this.notify();
     }
 }

lib/public/components/Filters/LhcFillsFilter/fillNumberFilter.js

@@ -14,31 +14,16 @@
 import { h } from '/js/src/index.js';
 import { iconX } from '/js/src/icons.js';
 import { switchInput } from '../../../common/form/switchInput.js';
-
-/**
- * Returns a text input field that can be used to filter logs by author
- *
- * @param {AuthorFilterModel} authorFilterModel The author filter model object
- * @returns {Component} A text box that allows the user to enter an author substring to match against all logs
- */
-const authorFilterTextInput = (authorFilterModel) => h('input.w-40', {
-    type: 'text',
-    id: 'authorFilterText',
-    value: authorFilterModel.raw,
-    oninput: (e) => authorFilterModel.update(e.target.value),
-});
+import { rawTextFilter } from '../../common/filters/rawTextFilter.js';
 
 /**
  * Returns a button that can be used to reset the author filter.
  *
  * @param {AuthorFilterModel} authorFilterModel The author filter model object
  * @return {Component} A button that can be used to reset the author filter
  */
-const resetAuthorFilterButton = (authorFilterModel) => h(
-    '.btn.btn-pill.f7',
-    { disabled: authorFilterModel.isEmpty, onclick: () => authorFilterModel.clear() },
-    iconX(),
-);
+const resetAuthorFilterButton = (authorFilterModel) =>
+    h('.btn.btn-pill.f7', { disabled: authorFilterModel.isEmpty, onclick: () => authorFilterModel.clear() }, iconX());
 
 /**
  * Returns a toggle that can be used to exclude anonymous authors
@@ -55,11 +40,11 @@ export const excludeAnonymousLogAuthorToggle = (authorFilterModel) => switchInpu
 /**
  * Returns a authorFilter component with text input, reset button, and anonymous exclusion button.
  *
- * @param {LogModel} logModel the log model object
- * @returns {Component} the author filter component
+ * @param {AuthorFilterModel} authorFilterModel the authorFilterModel
+ * @return {Component} the author filter component
  */
-export const authorFilter = ({ authorFilter }) => h('.flex-row.items-center.g3', [
-    authorFilterTextInput(authorFilter),
-    resetAuthorFilterButton(authorFilter),
-    excludeAnonymousLogAuthorToggle(authorFilter),
+export const authorFilter = (authorFilterModel) => h('.flex-row.items-center.g3', [
+    rawTextFilter(authorFilterModel, { classes: ['w-50'], id: 'authorFilterText', value: authorFilterModel.raw, placeholder: 'e.g. John Doe' }),
+    resetAuthorFilterButton(authorFilterModel),
+    excludeAnonymousLogAuthorToggle(authorFilterModel),
 ]);