[O2B-1173] Remove TST detector from RCT views (#1427)

* docs

* update tests

* revoke

* filter in model

* add

* refactor

* docs

* cleanup

Author: xsalonx

lib/public/services/detectors/detectorsProvider.js

@@ -14,6 +14,8 @@
 import { Observable } from '/js/src/index.js';
 import { getRemoteData } from '../../utilities/fetch/getRemoteData.js';
 
+const TST_DETECTOR_NAME = 'TST';
+
 /**
  * Service class to fetch detectors from the backend
  */
@@ -39,6 +41,17 @@ export class DetectorsProvider extends Observable {
 
         return this._allDetectors;
     }
+
+    /**
+     * Returns the list of all the physical available detectors
+     * E.g `TST` detector is not phsycial system so it is no included in the results
+     *
+     * @return {Promise<Detector[]>} the list of all physcial detectors
+     */
+    async getPhysical() {
+        await this.getAll();
+        return this._allDetectors.filter(({ name }) => name !== TST_DETECTOR_NAME);
+    }
 }
 
 export const detectorsProvider = new DetectorsProvider();

lib/public/views/Runs/RunPerDataPass/RunsPerDataPassOverviewModel.js

@@ -34,15 +34,16 @@ export class RunsPerDataPassOverviewModel extends RunsOverviewModel {
     }
 
     /**
-     * Retrieve a list of detector types from detectorsProvider
+     * Retrieve a list of physcial detector from detectorsProvider
      *
      * @return {Promise<void>} resolves once the data has been fetched
      * @private
      */
     async _fetchDetectors() {
         this._detectors.setCurrent(RemoteData.loading());
         try {
-            this._detectors.setCurrent(RemoteData.success(await detectorsProvider.getAll()));
+            const detectors = await detectorsProvider.getPhysical();
+            this._detectors.setCurrent(RemoteData.success(detectors));
         } catch (error) {
             this._detectors.setCurrent(RemoteData.failure(error));
         }

lib/public/views/Runs/RunPerPeriod/RunsPerLhcPeriodOverviewModel.js

@@ -31,15 +31,16 @@ export class RunsPerLhcPeriodOverviewModel extends RunsOverviewModel {
     }
 
     /**
-     * Retrieve a list of detector types from detectorsProvider
+     * Retrieve a list of physcial detector from detectorsProvider
      *
      * @return {Promise<void>} resolves once the data has been fetched
      * @private
      */
     async _fetchDetectors() {
         this._detectors.setCurrent(RemoteData.loading());
         try {
-            this._detectors.setCurrent(RemoteData.success(await detectorsProvider.getAll()));
+            const detectors = await detectorsProvider.getPhysical();
+            this._detectors.setCurrent(RemoteData.success(detectors));
         } catch (error) {
             this._detectors.setCurrent(RemoteData.failure(error));
         }

test/public/runs/runsPerDataPass.overview.test.js

@@ -44,7 +44,6 @@ const DETECTORS = [
     'TOF',
     'TPC',
     'TRD',
-    'TST',
     'ZDC',
 ];
 

test/public/runs/runsPerPeriod.overview.test.js

@@ -41,7 +41,6 @@ const DETECTORS = [
     'TOF',
     'TPC',
     'TRD',
-    'TST',
     'ZDC',
 ];