Skip to content

Commit c576760

Browse files
author
NarrowsProjects
committed
chore: explicitly define comma in array joins
1 parent f54e70d commit c576760

3 files changed

Lines changed: 3 additions & 3 deletions

File tree

lib/domain/enums/NonPhysicsProductionsNamesWords.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,4 +24,4 @@ module.exports.NonPhysicsProductionsNamesWords = NonPhysicsProductionsNamesWords
2424

2525
module.exports.NON_PHYSICS_PRODUCTIONS_NAMES_WORDS = Object.values(NonPhysicsProductionsNamesWords);
2626

27-
module.exports.NON_PHYSICS_PRODUCTIONS_NAMES_TOTAL_LENGTH = Object.values(NonPhysicsProductionsNamesWords).join().length;
27+
module.exports.NON_PHYSICS_PRODUCTIONS_NAMES_TOTAL_LENGTH = Object.values(NonPhysicsProductionsNamesWords).join(',').length;

lib/public/components/Filters/RunsFilter/DetectorsFilterModel.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ export class DetectorsFilterModel extends FilterModel {
6262
operator: this._combinationOperatorModel.current,
6363
};
6464
if (!this.isNone()) {
65-
normalized.values = this._dropdownModel.selected.join();
65+
normalized.values = this._dropdownModel.normalized;
6666
}
6767
return normalized;
6868
}

lib/public/components/common/selection/SelectionModel.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -373,6 +373,6 @@ export class SelectionModel extends Observable {
373373
* @return {string|string[]|boolean|boolean[]|number|number[]|SelectionOption|SelectionOption[]} the normalized value
374374
*/
375375
get normalized() {
376-
return (this._allowEmpty || this._multiple) ? this.selected.join() : this.current;
376+
return (this._allowEmpty || this._multiple) ? this.selected.join(',') : this.current;
377377
}
378378
}

0 commit comments

Comments
 (0)