[O2B-1536] Keep EOR lastEditedName out of patch; preserve for UI

Author: isaachilly

lib/public/views/Runs/Details/RunDetailsModel.js

@@ -53,6 +53,7 @@ export class RunDetailsModel extends Observable {
         this.editionTagPickerModel = new TagSelectionDropdownModel();
         this._runPatch = new RunPatch();
         this._runPatch.bubbleTo(this);
+        this._eorReasonLastEditedNames = [];
 
         this._tabbedPanelModel = new RunDetailsTabbedPanelModel();
         this._tabbedPanelModel.bubbleTo(this);
@@ -278,6 +279,14 @@ export class RunDetailsModel extends Observable {
         return this._runPatch;
     }
 
+    /**
+     * Returns the list of last edited names for EOR reasons, to be displayed in the edit form so as not to get added to patch
+     * @return {string[]} the list of last edited names for EOR reasons
+     */
+    get eorReasonLastEditedNames() {
+        return this._eorReasonLastEditedNames;
+    }
+
     /**
      * Returns the model for bottom-page tabs
      *
@@ -301,6 +310,8 @@ export class RunDetailsModel extends Observable {
             this._runPatch = new RunPatch(run);
             this._runPatch.bubbleTo(this);
 
+            this._eorReasonLastEditedNames = (run.eorReasons || []).map((eorReason) => eorReason.lastEditedName ?? null);
+
             this.editionTagPickerModel = new TagSelectionDropdownModel({ defaultSelection: run.tags.map(tagToOption) });
             this._tabbedPanelModel.runNumber = run.runNumber;
             this._runNumber = run.runNumber;

lib/public/views/Runs/Details/RunPatch.js

@@ -126,11 +126,10 @@ export class RunPatch extends Observable {
         } = this._run || {};
 
         this._runQuality = runQuality;
-        this._eorReasons = eorReasons.map(({ id, description, reasonTypeId, lastEditedName }) => ({
+        this._eorReasons = eorReasons.map(({ id, description, reasonTypeId }) => ({
             id,
             description,
             reasonTypeId,
-            lastEditedName,
         }));
         this._tags = tags.map(({ text }) => text);
 

lib/public/views/Runs/format/editRunEorReasons.js

@@ -93,8 +93,9 @@ export const editRunEorReasons = (runDetailsModel) => {
                  * added EOR reason is still displayed
                  */
                 runDetailsModel.runPatch.eorReasons.length > 0
-                    ? runDetailsModel.runPatch.eorReasons.map((eorReason) => {
-                        const { reasonTypeId, description, lastEditedName } = eorReason;
+                    ? runDetailsModel.runPatch.eorReasons.map((eorReason, index) => {
+                        const { reasonTypeId, description } = eorReason;
+                        const lastEditedName = runDetailsModel.eorReasonLastEditedNames[index];
                         const { category = '-', title } = eorReasonTypes.find((eorReasonType) => eorReasonType.id === reasonTypeId) || {};
                         const titleString = title ? ` - ${title}` : '';
                         const descriptionString = description ? ` - ${description}` : '';
@@ -110,7 +111,7 @@ export const editRunEorReasons = (runDetailsModel) => {
                                     }, iconTrash()),
                                     h('.w-wrapped', `${category} ${titleString} ${descriptionString}`),
                                 ]),
-                                h('.w-wrapped', `${lastEditedName}`),
+                                h('.w-wrapped', `${lastEditedName ? `${lastEditedName}` : ''}`),
                             ],
                         );
                     })