rename

Author: xsalonx

lib/domain/enums/QcSummaryProperties.js

@@ -12,8 +12,8 @@
  */
 
 exports.QcSummarProperties = {
-    badEffectiveRunCoverage: 'badEffectiveRunCoverage',
-    explicitlyNotBadEffectiveRunCoverage: 'explicitlyNotBadEffectiveRunCoverage',
-    missingVerificationsCount: 'missingVerificationsCount',
-    mcReproducible: 'mcReproducible',
+    BAD_EFFECTIVE_RUN_COVERAGE: 'badEffectiveRunCoverage',
+    EXPLICITELY_NOT_BAD_EFFECTIVE_RUN_COVERAGE: 'explicitlyNotBadEffectiveRunCoverage',
+    MISSING_VERIFICATIONS: 'missingVerificationsCount',
+    MC_REPRODUCIBLE: 'mcReproducible',
 };

lib/server/services/qualityControlFlag/GaqService.js

@@ -61,10 +61,10 @@ class GaqService {
         ]) => [
             runNumber,
             {
-                [QcSummarProperties.badEffectiveRunCoverage]: badCoverage + (mcReproducibleAsNotBad ? 0 : mcReproducibleCoverage),
-                [QcSummarProperties.explicitlyNotBadEffectiveRunCoverage]: goodCoverage + (mcReproducibleAsNotBad ? mcReproducibleCoverage : 0),
-                [QcSummarProperties.mcReproducible]: mcReproducibleCoverage > 0,
-                [QcSummarProperties.missingVerificationsCount]: flagsIds.length - verifiedFlagsIds.length,
+                [QcSummarProperties.BAD_EFFECTIVE_RUN_COVERAGE]: badCoverage + (mcReproducibleAsNotBad ? 0 : mcReproducibleCoverage),
+                [QcSummarProperties.EXPLICITELY_NOT_BAD_EFFECTIVE_RUN_COVERAGE]: goodCoverage + (mcReproducibleAsNotBad ? mcReproducibleCoverage : 0),
+                [QcSummarProperties.MC_REPRODUCIBLE]: mcReproducibleCoverage > 0,
+                [QcSummarProperties.MISSING_VERIFICATIONS]: flagsIds.length - verifiedFlagsIds.length,
             },
         ]);
 

lib/server/services/qualityControlFlag/QcFlagSummaryService.js

@@ -55,19 +55,19 @@ class QcFlagSummaryService {
         } = partialSummaryUnit;
 
         if (bad) {
-            summaryUnit[QcSummarProperties.badEffectiveRunCoverage] = effectiveRunCoverage;
-            summaryUnit[QcSummarProperties.mcReproducible] =
-                mcReproducible || summaryUnit[QcSummarProperties.mcReproducible];
+            summaryUnit[QcSummarProperties.BAD_EFFECTIVE_RUN_COVERAGE] = effectiveRunCoverage;
+            summaryUnit[QcSummarProperties.MC_REPRODUCIBLE] =
+                mcReproducible || summaryUnit[QcSummarProperties.MC_REPRODUCIBLE];
         } else {
-            summaryUnit[QcSummarProperties.explicitlyNotBadEffectiveRunCoverage] = effectiveRunCoverage;
-            summaryUnit[QcSummarProperties.mcReproducible] =
-                mcReproducible || summaryUnit[QcSummarProperties.mcReproducible];
+            summaryUnit[QcSummarProperties.EXPLICITELY_NOT_BAD_EFFECTIVE_RUN_COVERAGE] = effectiveRunCoverage;
+            summaryUnit[QcSummarProperties.MC_REPRODUCIBLE] =
+                mcReproducible || summaryUnit[QcSummarProperties.MC_REPRODUCIBLE];
         }
-        if (summaryUnit[QcSummarProperties.badEffectiveRunCoverage] === undefined) {
-            summaryUnit[QcSummarProperties.badEffectiveRunCoverage] = 0;
+        if (summaryUnit[QcSummarProperties.BAD_EFFECTIVE_RUN_COVERAGE] === undefined) {
+            summaryUnit[QcSummarProperties.BAD_EFFECTIVE_RUN_COVERAGE] = 0;
         }
-        if (summaryUnit[QcSummarProperties.explicitlyNotBadEffectiveRunCoverage] === undefined) {
-            summaryUnit[QcSummarProperties.explicitlyNotBadEffectiveRunCoverage] = 0;
+        if (summaryUnit[QcSummarProperties.EXPLICITELY_NOT_BAD_EFFECTIVE_RUN_COVERAGE] === undefined) {
+            summaryUnit[QcSummarProperties.EXPLICITELY_NOT_BAD_EFFECTIVE_RUN_COVERAGE] = 0;
         }
     }
 
@@ -189,13 +189,13 @@ class QcFlagSummaryService {
                 summary[runNumber] = {};
             }
             if (!summary[runNumber][detectorId]) {
-                summary[runNumber][detectorId] = { [QcSummarProperties.mcReproducible]: false };
+                summary[runNumber][detectorId] = { [QcSummarProperties.MC_REPRODUCIBLE]: false };
             }
 
             const runDetectorSummary = summary[runNumber][detectorId];
 
-            runDetectorSummary[QcSummarProperties.missingVerificationsCount] =
-                (runDetectorSummary[QcSummarProperties.missingVerificationsCount] ?? 0) + missingVerificationsCount;
+            runDetectorSummary[QcSummarProperties.MISSING_VERIFICATIONS] =
+                (runDetectorSummary[QcSummarProperties.MISSING_VERIFICATIONS] ?? 0) + missingVerificationsCount;
 
             QcFlagSummaryService.mergeIntoSummaryUnit(runDetectorSummary, runDetectorSummaryForFlagTypesClass);
         }