change display when missing flag

Author: xsalonx

lib/public/views/QcFlags/ActiveColumns/gaqFlagsActiveColumns.js

@@ -32,19 +32,17 @@ const formatGeneralQuality = (contributingFlags, gaqDetectors) => {
     const allGood = flagTypes.every(({ bad }) => !bad);
     const someBadNotReproducible = flagTypes.some(({ bad, mcReproducible }) => bad && !mcReproducible);
 
-    const flagForSomeDetectorIsMissing = gaqDetectors.length !== contributingFlags.length;
     const missingVerifications = contributingFlags.some(({ verifications }) => verifications.length === 0);
-    const missingDataMessage = [
-        ... flagForSomeDetectorIsMissing ? [h('', 'No flag for some detector')] : [],
-        ... missingVerifications ? [h('', 'At least one flag is not verified')] : [],
-    ];
-
-    const missingDataTooltip = missingDataMessage.length
-        ? h('.d-inline-block.m1', tooltip(iconWarning(), h('.flex-column', missingDataMessage)))
+    const missingDataTooltip = missingVerifications
+        ? h('.d-inline-block.m1', tooltip(iconWarning(), h('.flex-column', h('', 'At least one flag is not verified'))))
         : null;
 
+    const flagForSomeDetectorIsMissing = gaqDetectors.length !== contributingFlags.length;
+
     let qualityDisplay = null;
-    if (allGood) {
+    if (flagForSomeDetectorIsMissing) {
+        qualityDisplay = h('.gray-darker.m2.badge', tooltip(iconBan(), 'No flag for some detector'));
+    } else if (allGood) {
         qualityDisplay = badge('good', { color: QcSummaryColors.ALL_GOOD });
     } else if (someBadNotReproducible) {
         qualityDisplay = badge('bad', { color: QcSummaryColors.ALL_BAD });