Skip to content

Commit d45eded

Browse files
author
NarrowsProjects
committed
chore: add missing reset filtering params for logs
1 parent 1a6fe58 commit d45eded

2 files changed

Lines changed: 7 additions & 6 deletions

File tree

lib/public/components/Filters/common/filtersPanelPopover.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,8 @@ const filtersToggleContentHeader = (filteringModel) => h('.flex-row.justify-betw
4848
'button#reset-filters.btn.btn-danger',
4949
{
5050
onclick: () => filteringModel.resetFiltering
51-
? filteringModel.resetFiltering()
52-
: filteringModel.reset(true),
51+
? filteringModel.resetFiltering(true, true)
52+
: filteringModel.reset(true, true),
5353
disabled: !filteringModel.isAnyFilterActive(),
5454
},
5555
'Reset all filters',

lib/public/views/Logs/Overview/LogsOverviewModel.js

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -126,11 +126,12 @@ export class LogsOverviewModel extends Observable {
126126
/**
127127
* Reset all filtering, sorting and pagination settings to their default values
128128
*
129-
* @param {boolean} fetch Whether to refetch all logs after filters have been reset
130-
* @return {undefined}
129+
* @param {boolean} _fetch Whether to refetch all data after filters have been reset
130+
* @param {boolean} [clearUrl=false] if true filters will be removed from the url
131+
* @return {void}
131132
*/
132-
reset(fetch = true) {
133-
this._filteringModel.reset();
133+
reset(_fetch = true, clearUrl = false) {
134+
this._filteringModel.reset(false, clearUrl);
134135
this._pagination.reset();
135136

136137
if (fetch) {

0 commit comments

Comments
 (0)