[O2B-1148] Runs filtering is not considered in runs export (#1392)

* fix

* add test

* change selector

* extend test

* extend test

* amend remove waitForTimeout

Author: xsalonx

lib/public/views/Runs/Overview/RunsOverviewModel.js

@@ -70,6 +70,15 @@ export class RunsOverviewModel extends OverviewPageModel {
         return `/api/runs?${paramsString}`;
     }
 
+    // eslint-disable-next-line valid-jsdoc
+    /**
+     * @inheritdoc
+     */
+    async load() {
+        this._allRuns = RemoteData.NotAsked();
+        super.load();
+    }
+
     /**
      * Create the export with the variables set in the model, handling errors appropriately
      * @param {object[]} runs The source content.

test/public/runs/overview.test.js

@@ -11,6 +11,8 @@
  * or submit itself to any jurisdiction.
  */
 
+const path = require('path');
+const fs = require('fs');
 const chai = require('chai');
 const {
     defaultBefore,
@@ -26,6 +28,7 @@ const {
 const { RunDefinition } = require('../../../lib/server/services/run/getRunDefinition.js');
 const { RUN_QUALITIES, RunQualities } = require('../../../lib/domain/enums/RunQualities.js');
 const { fillInput, getPopoverContent, getInnerText } = require('../defaults.js');
+const { waitForDownload } = require('../../utilities/waitForDownload');
 
 const { expect } = chai;
 
@@ -1057,6 +1060,79 @@ module.exports = () => {
         expect(await page.$eval(EXPORT_RUNS_TRIGGER_SELECTOR, (button) => button.disabled)).to.be.true;
     });
 
+    it('should successfully export filtered runs', async () => {
+        await goToPage(page, 'run-overview');
+
+        const downloadPath = path.resolve('./download');
+
+        // Check accessibility on frontend
+        const session = await page.target().createCDPSession();
+        await session.send('Browser.setDownloadBehavior', {
+            behavior: 'allow',
+            downloadPath: downloadPath,
+            eventsEnabled: true,
+        });
+
+        let downloadFilesNames;
+        const targetFileName = 'runs.json';
+        let runs;
+        let exportModal;
+
+        // First export
+        await page.$eval(EXPORT_RUNS_TRIGGER_SELECTOR, (button) => button.click());
+        await page.waitForSelector('#export-runs-modal');
+        exportModal = await page.$('#export-runs-modal');
+        expect(exportModal).to.not.be.null;
+        const exportButtonText = await page.$eval('#send', (button) => button.innerText);
+        expect(exportButtonText).to.be.eql('Export');
+
+        await page.select('.form-control', 'runQuality', 'runNumber');
+        await page.$eval('#send', (button) => button.click());
+
+        await waitForDownload(session);
+
+        // Check download
+        downloadFilesNames = fs.readdirSync(downloadPath);
+        expect(downloadFilesNames.filter((name) => name == targetFileName)).to.be.lengthOf(1);
+        runs = JSON.parse(fs.readFileSync(path.resolve(downloadPath, targetFileName)));
+
+        expect(runs).to.be.lengthOf(100);
+        expect(runs.every(({ runQuality, runNumber, ...otherProps }) =>
+            runQuality && runNumber && Object.keys(otherProps).length === 0)).to.be.true;
+        downloadFilesNames = fs.readdirSync(downloadPath);
+        fs.unlinkSync(path.resolve(downloadPath, targetFileName));
+        downloadFilesNames = fs.readdirSync(downloadPath);
+
+        // Second export
+
+        // Apply filtering
+        const filterInputSelectorPrefix = '#runQualityCheckbox';
+        const badFilterSelector = `${filterInputSelectorPrefix}bad`;
+
+        await pressElement(page, '#openFilterToggle');
+        await page.waitForSelector(badFilterSelector);
+        await page.$eval(badFilterSelector, (element) => element.click());
+        await page.waitForSelector('div.atom-spinner');
+        await page.waitForSelector(EXPORT_RUNS_TRIGGER_SELECTOR);
+
+        ///// Download
+        await page.$eval(EXPORT_RUNS_TRIGGER_SELECTOR, (button) => button.click());
+        await page.waitForSelector('#export-runs-modal');
+        exportModal = await page.$('#export-runs-modal');
+        expect(exportModal).to.not.be.null;
+
+        await page.select('.form-control', 'runQuality', 'runNumber');
+        await page.$eval('#send', (button) => button.click());
+
+        await waitForDownload(session);
+
+        // Check download
+        downloadFilesNames = fs.readdirSync(downloadPath);
+        expect(downloadFilesNames.filter((name) => name == targetFileName)).to.be.lengthOf(1);
+        runs = JSON.parse(fs.readFileSync(path.resolve(downloadPath, targetFileName)));
+        expect(runs).to.have.all.deep.members([{ runNumber: 2, runQuality: 'bad' }, { runNumber: 1, runQuality: 'bad' }]);
+    });
+
     it('should successfully navigate to the LHC fill details page', async () => {
         await reloadPage(page);
 

test/utilities/waitForDownload.js

@@ -0,0 +1,32 @@
+/*
+ *  @license
+ *  Copyright CERN and copyright holders of ALICE O2. This software is
+ *  distributed under the terms of the GNU General Public License v3 (GPL
+ *  Version 3), copied verbatim in the file "COPYING".
+ *
+ *  See http://alice-o2.web.cern.ch/license for full licensing information.
+ *
+ *  In applying this license CERN does not waive the privileges and immunities
+ *  granted to it by virtue of its status as an Intergovernmental Organization
+ *  or submit itself to any jurisdiction.
+ */
+
+/**
+ * Create promise which is resolved when last initiated download is completed and rejected when canceled
+ * @param {CDPSession} session puppetear CDP session
+ * @return {Promise} promise
+ * !!! Downloading requires to set 'Browser.setDownloadBehavior' behaviour on the given CDP session
+ */
+async function waitForDownload(session) {
+    return new Promise((resolve, reject) => {
+        session.on('Browser.downloadProgress', (event) => {
+            if (event.state === 'completed') {
+                resolve();
+            } else if (event.state === 'canceled') {
+                reject();
+            }
+        });
+    });
+}
+
+exports.waitForDownload = waitForDownload;