Skip to content

Commit ec225e3

Browse files
[O2B-883] Fix runs quality border triggering balloon display (#1375)
* [O2B-883] Fix runs quality border triggering balloon display * Fix linter
1 parent e9e67a9 commit ec225e3

3 files changed

Lines changed: 7 additions & 6 deletions

File tree

lib/public/app.css

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,14 +15,14 @@ html, body {
1515

1616
.b1 { border-style: solid; border-width: 1px; }
1717
.bt1 { border-top: 1px solid }
18+
.bb3 { border-bottom: 3px solid }
1819
.b-gray-light { border-color: var(--color-gray-light) }
1920
.b-warning { border-color: var(--color-warning); }
2021
.b-danger { border-color: var(--color-danger); }
2122
.b-success { border-color: var(--color-success); }
2223
.b-primary { border-color: var(--color-primary); }
23-
24-
.b-underline-good { border-bottom: 4px solid var(--color-success); }
25-
.b-underline-bad { border-bottom: 4px dashed var(--color-danger); }
24+
.b-good { border-color: var(--color-success); }
25+
.b-bad { border-color: var(--color-danger); border-style: dashed }
2626

2727
.bg-light-blue {
2828
background-color: var(--color-light-blue) !important;

lib/public/components/common/popover/overflowBalloon.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,9 +25,9 @@ import { PopoverAnchors } from './PopoverEngine.js';
2525
*/
2626
const doesElementOverflow = (element) => {
2727
const overflowHorizontally = Boolean(element) && element.offsetWidth < element.scrollWidth;
28-
const overvlowVertically = Boolean(element) && element.offsetHeight < element.scrollHeight;
28+
const overflowVertically = Boolean(element) && element.offsetHeight < element.scrollHeight;
2929

30-
return overflowHorizontally || overvlowVertically;
30+
return overflowHorizontally || overflowVertically;
3131
};
3232

3333
/**

lib/public/views/Runs/format/formatRunDetectorsInline.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,4 +45,5 @@ export const formatRunDetectorsInline = (detectorsQualities, nDetectors) => {
4545
* @param {RunDetectorQuality} detectorsQuality The detector with its quality
4646
* @return {string} The class of the detecor
4747
*/
48-
const detectorStyleClass = (detectorsQuality) => detectorsQuality.quality === RunDetectorQualities.GOOD ? 'b-underline-good' : 'b-underline-bad';
48+
const detectorStyleClass = (detectorsQuality) => 'd-inline-block bb3'
49+
+ ` ${detectorsQuality.quality === RunDetectorQualities.GOOD ? 'b-good' : 'b-bad'}`;

0 commit comments

Comments
 (0)