Skip to content

Commit eeefa7f

Browse files
author
NarrowsProjects
committed
Merge branch 'main' into improv/O2B-1549/Migrate-AnchoredSimulationPassesOverviewModel-and-SimulationPassesPerLhcPeriodOverviewModel-to-use-FilteringModel-pattern
2 parents f9c1adb + 37b6ee1 commit eeefa7f

46 files changed

Lines changed: 1006 additions & 925 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ RUN apk add --no-cache \
2222
freetype=2.13.2-r0 \
2323
freetype-dev=2.13.2-r0 \
2424
harfbuzz=8.5.0-r0 \
25-
ca-certificates=20250911-r0
25+
ca-certificates=20260413-r0
2626

2727
# Tell Puppeteer to skip installing Chrome. We'll be using the installed package.
2828
ENV PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=true

lib/database/seeders/20240404100811-qc-flags.js

Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -281,6 +281,21 @@ module.exports = {
281281
created_at: '2024-08-12 12:00:10',
282282
updated_at: '2024-08-12 12:00:10',
283283
},
284+
{
285+
id: 103,
286+
deleted: true,
287+
from: null,
288+
to: '2019-08-08 20:50:00',
289+
comment: 'deleted flag',
290+
291+
run_number: 56,
292+
flag_type_id: 13, // Bad
293+
created_by_id: 2,
294+
detector_id: 7, // FT0
295+
296+
created_at: '2024-08-12 12:00:15',
297+
updated_at: '2024-08-12 12:00:15',
298+
},
284299

285300
// Run : 56, ITS
286301
{
@@ -394,6 +409,12 @@ module.exports = {
394409
from: '2019-08-08 20:50:00',
395410
to: null,
396411
},
412+
{
413+
id: 103,
414+
flag_id: 103,
415+
from: null,
416+
to: '2019-08-08 20:50:00',
417+
},
397418

398419
// Run : 56, ITS
399420
{

lib/public/components/Filters/LhcFillsFilter/fillNumberFilter.js

Lines changed: 0 additions & 25 deletions
This file was deleted.

lib/public/components/Filters/LhcFillsFilter/schemeNameFilter.js

Lines changed: 0 additions & 25 deletions
This file was deleted.

lib/public/components/Filters/LogsFilter/author/AuthorFilterModel.js

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,4 +51,16 @@ export class AuthorFilterModel extends RawTextFilterModel {
5151

5252
this.notify();
5353
}
54+
55+
/**
56+
* Reset the filter to its default value and notify the observers if the reset changed anything.
57+
*
58+
* @return {void}
59+
*/
60+
clear() {
61+
if (!this.isEmpty) {
62+
super.reset();
63+
this.notify();
64+
}
65+
}
5466
}

lib/public/components/Filters/LogsFilter/author/authorFilter.js

Lines changed: 8 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -22,11 +22,8 @@ import { rawTextFilter } from '../../common/filters/rawTextFilter.js';
2222
* @param {AuthorFilterModel} authorFilterModel The author filter model object
2323
* @return {Component} A button that can be used to reset the author filter
2424
*/
25-
const resetAuthorFilterButton = (authorFilterModel) => h(
26-
'.btn.btn-pill.f7',
27-
{ disabled: authorFilterModel.isEmpty, onclick: () => authorFilterModel.reset() },
28-
iconX(),
29-
);
25+
const resetAuthorFilterButton = (authorFilterModel) =>
26+
h('.btn.btn-pill.f7', { disabled: authorFilterModel.isEmpty, onclick: () => authorFilterModel.clear() }, iconX());
3027

3128
/**
3229
* Returns a toggle that can be used to exclude anonymous authors
@@ -43,16 +40,11 @@ export const excludeAnonymousLogAuthorToggle = (authorFilterModel) => switchInpu
4340
/**
4441
* Returns a authorFilter component with text input, reset button, and anonymous exclusion button.
4542
*
46-
* @param {LogsOverviewModel} logsOverviewModel the log overview model
47-
* @param {FilteringModel} logsOverviewModel.filteringModel the runs overview model
48-
* @return {Component} the filter component
43+
* @param {AuthorFilterModel} authorFilterModel the authorFilterModel
44+
* @return {Component} the author filter component
4945
*/
50-
export const authorFilter = ({ filteringModel }) => h('.flex-row.items-center.g3', [
51-
rawTextFilter(filteringModel.get('author'), {
52-
classes: ['w-40'],
53-
id: 'authorFilterText',
54-
value: filteringModel.get('author').raw,
55-
}),
56-
resetAuthorFilterButton(filteringModel.get('author')),
57-
excludeAnonymousLogAuthorToggle(filteringModel.get('author')),
46+
export const authorFilter = (authorFilterModel) => h('.flex-row.items-center.g3', [
47+
rawTextFilter(authorFilterModel, { classes: ['w-50'], id: 'authorFilterText', value: authorFilterModel.raw, placeholder: 'e.g. John Doe' }),
48+
resetAuthorFilterButton(authorFilterModel),
49+
excludeAnonymousLogAuthorToggle(authorFilterModel),
5850
]);

lib/public/components/Filters/LogsFilter/created.js

Lines changed: 0 additions & 53 deletions
This file was deleted.

lib/public/components/Filters/LogsFilter/environments.js

Lines changed: 0 additions & 28 deletions
This file was deleted.

lib/public/components/Filters/LogsFilter/runs.js

Lines changed: 0 additions & 28 deletions
This file was deleted.

lib/public/components/Filters/RunsFilter/runNumbersFilter.js

Lines changed: 0 additions & 25 deletions
This file was deleted.

0 commit comments

Comments
 (0)