fix issue of mcReproducible always being active

Author: NarrowsProjects

lib/public/components/Filters/common/filtersPanelPopover.js

@@ -174,10 +174,13 @@ const pasteButtonOption = (model) => {
 /**
  * A indicates if any filters are currently active on the page
  *
- * @param {FilteringModel} filteringModel the filtering model
+ * @param {FilteringModel} model the filtering model
  * @returns {Component} the active filters indicator
  */
-const activeFilterIndicator = (filteringModel) => {
+const activeFilterIndicator = (model) => {
+    // Sometimes, the overview model is passed to filterPanelPopover instead of the filteringmodel (e.g. envirionments)
+    const { filteringModel = model } = model;
+
     const hasActiveFilters = filteringModel.isAnyFilterActive();
     const innerText = `Filters ${hasActiveFilters ? 'Active' : 'Inactive'}`;
 

lib/public/views/Runs/Overview/RunsWithQcModel.js

@@ -78,7 +78,7 @@ export class RunsWithQcModel extends RunsOverviewModel {
 
         this._observablesQcFlagsSummaryDependsOn$ = null;
         // This filter instance will be added as a sub-filter for a MultiCompositionFilter and a GaqFilter later.
-        this._mcReproducibleAsNotBad = new ToggleFilterModel();
+        this._mcReproducibleAsNotBad = new ToggleFilterModel(false, true);
 
         this._runDetectorsSelectionModel = new RunDetectorsSelectionModel();
         this._runDetectorsSelectionModel.bubbleTo(this);