logic fixes

Author: xsalonx

lib/domain/dtos/filters/RunFilterDto.js

@@ -128,9 +128,9 @@ exports.RunFilterDto = Joi.object({
         })
         .custom((detectorsQcObj, helpers) => {
             const [{ dataPassIds, simulationPassIds, lhcPeriodIds }] = helpers.state.ancestors;
-            const filters = [dataPassIds, simulationPassIds, lhcPeriodIds].filter(({ length } = {}) => length === 1);
+            const runsCollectionFilters = [dataPassIds, simulationPassIds, lhcPeriodIds].filter(({ length } = {}) => length >= 1);
 
-            if (filters.length !== 1) {
+            if (runsCollectionFilters.length !== 1 || runsCollectionFilters[0].length !== 1) {
                 return helpers.error('any.invalid', {
                     message: 'Filtering by detector not-bad fraction is allowed only with exactly one of: ' +
                     'dataPassIds, simulationPassIds, lhcPeriodIds with exactly one ID.',

lib/server/services/qualityControlFlag/QcFlagSummaryService.js

@@ -78,15 +78,15 @@ class QcFlagSummaryService {
      * @param {number} [scope.dataPassId] data pass id - exclusive with other options
      * @param {number} [scope.simulationPassId] simulation pass id - exclusive with other options
      * @param {number} [scope.lhcPeriodId] id of LHC Period - exclusive with other options
-     * @param {number} [scope.dplDetectorIds] ids of dpl detectors
+     * @param {number[]} [scope.dplDetectorIds] ids of dpl detectors
      * @param {object} [options] additional options
      * @param {boolean} [options.mcReproducibleAsNotBad = false] if set to true, `Limited Acceptance MC Reproducible` flag type is treated as
      *     good one
      * @return {Promise<QcSummary>} summary
      */
     async getSummary({ dataPassId, simulationPassId, lhcPeriodId, dplDetectorIds }, { mcReproducibleAsNotBad = false } = {}) {
-        if (Boolean(dataPassId) + Boolean(simulationPassId) + Boolean(lhcPeriodId) > 1) {
-            throw new BadParameterError('`dataPassId`, `simulationPassId` and `lhcPeriodId` are exclusive options');
+        if (Boolean(dataPassId) + Boolean(simulationPassId) + Boolean(lhcPeriodId) !== 1) {
+            throw new BadParameterError('One and exactly one of `dataPassId`, `simulationPassId` and `lhcPeriodId` is required');
         }
 
         const queryBuilder = dataSource.createQueryBuilder()