Merge branch 'main' into xsalonx/fix/beam-types

Author: xsalonx

package-lock.json

@@ -45,19 +45,19 @@
     "proto/"
   ],
   "devDependencies": {
-    "@eslint/js": "^9.34.0",
+    "@eslint/js": "^9.35.0",
     "@stylistic/eslint-plugin-js": "^4.4.1",
     "@types/d3": "7.4.0",
     "chai": "4.5.0",
     "date-and-time": "3.6.0",
     "eslint": "^9.34.0",
-    "eslint-plugin-jsdoc": "^54.1.0",
+    "eslint-plugin-jsdoc": "^55.0.3",
     "globals": "^16.3.0",
     "js-yaml": "4.1.0",
     "mocha": "11.7.0",
     "nodemon": "3.1.3",
     "nyc": "17.1.0",
-    "puppeteer": "24.17.0",
+    "puppeteer": "24.18.0",
     "puppeteer-to-istanbul": "1.4.0",
     "sequelize-cli": "6.6.0",
     "sinon": "21.0.0",

package.json

@@ -74,6 +74,7 @@ module.exports = () => {
         it('should successfully get non-empty QC flag summary for data pass', async () => {
             const response = await request(server).get('/api/qcFlags/summary?dataPassId=1');
             expect(response.status).to.be.equal(200);
+
             const { body: { data } } = response;
             expect(data).to.be.eql({
                 106: {

test/api/qcFlags.test.js

@@ -179,7 +179,8 @@ module.exports.waitForTableTotalRowsCountToEqual = async (page, amount) => {
             amount,
         );
     } catch {
-        const actualCount = (await page.$$('#totalRowsCount')).innerText;
+        const element = await page.$$('#totalRowsCount')
+        const actualCount = element.innerText;
         throw new Error(`Expected total rows count ${amount}, but got ${actualCount}`);
     }
 };
@@ -893,3 +894,26 @@ module.exports.getPeriodInputsSelectors = (popoverSelector) => {
         toTimeSelector: `${commonInputsAncestor} > div:nth-child(2) input:nth-child(2)`,
     };
 };
+
+/**
+ * Open filtering panel
+ * @param {puppeteer.page} page page handler
+ */
+module.exports.openFilteringPanel = async (page) => {
+    await page.waitForSelector('#reset-filters', { visible: true }).catch(async () => {
+        await this.pressElement(page, '#openFilterToggle');
+    })
+};
+
+/**
+ * Reset standard filtering
+ * Excecution of this function does not change visibility of filtering popover
+ * @param {puppeteer.page} page page handler
+ */
+module.exports.resetFilters = async (page) => {
+    await page.waitForSelector('#reset-filters', { visible: true }).then(() => this.pressElement(page, '#reset-filters')).catch(async () => {
+        await this.pressElement(page, '#openFilterToggle');
+        await this.pressElement(page, '#reset-filters');
+        await this.pressElement(page, '#openFilterToggle');
+    })
+};

test/public/defaults.js

@@ -11,7 +11,34 @@
  * or submit itself to any jurisdiction.
  */
 
-const { waitForNavigation, pressElement, getInnerText, expectUrlParams, waitForTableLength } = require('../defaults.js');
+const { waitForNavigation, pressElement, expectUrlParams, waitForTableLength } = require('../defaults.js');
+
+/**
+ * Navigate to runs overview page
+ *
+ * @param {Puppeteer.Page} page page
+ * @return {Promise<void>} promise
+ */
+exports.navigateToRunsOverview = async (page) => {
+    await waitForNavigation(page, () => pressElement(page, 'a#run-overview', true));
+};
+
+
+/**
+ * Navigate to Runs per LHC period
+ *
+ * @param {Puppeteer.Page} page page
+ * @param {number} lhcPeriodId id of lhc period on LHC Period overview page
+ * @param {number} expectedRowsCount expected number of rows on runs per data pass page
+ * @return {Promise<void>} promise
+ */
+exports.navigateToRunsPerLhcPeriod = async (page, lhcPeriodId, expectedRowsCount, tabPanel='detectorQualities') => {
+    await waitForNavigation(page, () => pressElement(page, 'a#lhc-period-overview', true));
+    await waitForNavigation(page, () => pressElement(page, `#row${lhcPeriodId}-associatedRuns a`, true));
+    await pressElement(page, `#${tabPanel}-tab`, true);
+    expectUrlParams(page, { page: 'runs-per-lhc-period', lhcPeriodId, panel: tabPanel }, ['pdpBeamType']);
+    await waitForTableLength(page, expectedRowsCount);
+};
 
 /**
  * Navigate to Runs per Data Pass page
@@ -32,6 +59,7 @@ exports.navigateToRunsPerDataPass = async (page, lhcPeriodId, dataPassId, expect
     await waitForTableLength(page, expectedRowsCount);
 };
 
+
 /**
  * Navigate to Runs per Simulation Pass page
  *