Skip to content

[O2B-1446] Allow flags creation to continue if initial one fails for sync#1902

Merged
graduta merged 3 commits into
mainfrom
improv/graduta/O2B-1446/do-not-drop-all-subsequent-qc-flags
May 28, 2025
Merged

[O2B-1446] Allow flags creation to continue if initial one fails for sync#1902
graduta merged 3 commits into
mainfrom
improv/graduta/O2B-1446/do-not-drop-all-subsequent-qc-flags

Conversation

@graduta

@graduta graduta commented May 28, 2025

Copy link
Copy Markdown
Member

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

Notable changes for developers:

  • QC SYNC flags are sent as early as O2 start time which will not fit the criteria of qcStartTime (a virtual looking at TF, TRG or O2 timestamps
  • this changes allows next flags to be created even if the first one failed to meet the interval criteria. Currently the entire list of qc flags would be rejected instead

Changes made to the database:

@graduta graduta self-assigned this May 28, 2025
@graduta graduta requested a review from martinboulais as a code owner May 28, 2025 15:07
@codecov

codecov Bot commented May 28, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.

Project coverage is 40.89%. Comparing base (767cac4) to head (b287462).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...erver/services/qualityControlFlag/QcFlagService.js 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1902      +/-   ##
==========================================
- Coverage   44.77%   40.89%   -3.88%     
==========================================
  Files        1018     1018              
  Lines       17123    17125       +2     
  Branches     3087     3087              
==========================================
- Hits         7667     7004     -663     
- Misses       9456    10121     +665     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@graduta graduta merged commit a3ba918 into main May 28, 2025
22 of 24 checks passed
@graduta graduta deleted the improv/graduta/O2B-1446/do-not-drop-all-subsequent-qc-flags branch May 28, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

1 participant