[O2B-1450] Update SYNTHETIC run definition

[graduta]

I have a JIRA ticket

• branch and/or PR name(s) include(s) JIRA ID
• issue has "Fix version" assigned
• issue "Status" is set to "In review"
• PR labels are selected

Notable changes for users:

• Run Definition of SYNTHETIC drops the check on readout_cfg_uri (as this is now consul config and not file) and adds run_type match criteria for SYNTHETIC or REPLAY

Notable changes for developers:

Changes made to the database:

[Copilot]

Pull Request Overview

This PR updates the SYNTHETIC run definition to no longer rely on readout_cfg_uri and instead match on run_type.name (SYNTHETIC or REPLAY). It adjusts fixtures, tests, core logic, and documentation accordingly.

• Replace PP/PBPB fixtures with REPLAY/SYNTHETIC and remove readoutCfgUri
• Update tests to expect the new subkeys and logic
• Modify getRunDefinition to use runType.name regex instead of URI checks
• Revise docs to describe the new run definition criteria

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
test/mocks/mock-run.js	Updated SYNTHETIC fixtures: removed URI and renamed keys
test/lib/server/services/run/getRunDefinition.test.js	Adjusted expectations to use SYNTHETIC.REPLAY and .SYNTHETIC
test/lib/server/services/run/RunService.test.js	Updated creation test to use SYNTHETIC.SYNTHETIC
lib/server/services/run/getRunDefinition.js	Removed URI check and switched to runType.name regex
docs/RUN_DEFINITIONS.md	Updated SYNTHETIC section; added run_type criteria and retained historical definitions

Comments suppressed due to low confidence (3)

test/mocks/mock-run.js:173

• [nitpick] The nested object under SYNTHETIC.REPLAY and SYNTHETIC.SYNTHETIC may be confusing. Consider adding a comment or using more descriptive keys to clarify the relationship between the top-level SYNTHETIC fixture and its subtypes.

        REPLAY: {

test/lib/server/services/run/getRunDefinition.test.js:42

• These tests cover uppercase REPLAY and SYNTHETIC. Add cases with mixed or lowercase runType.name values to ensure the regex matching remains truly case-insensitive.

        expect(getRunDefinition(SYNTHETIC.REPLAY)).to.equal(RunDefinition.SYNTHETIC);

docs/RUN_DEFINITIONS.md:60

• The 'Previous RUN Definitions' section still shows the old readout_cfg_uri criteria without marking it as deprecated, which could confuse readers. Consider clearly labeling it as historical or removing it altogether.

## Previous RUN Definitions

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.89%. Comparing base (b39541c) to head (247424f).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1913   +/-   ##
=======================================
  Coverage   40.89%   40.89%           
=======================================
  Files        1019     1019           
  Lines       17133    17132    -1     
  Branches     3090     3089    -1     
=======================================
  Hits         7006     7006           
+ Misses      10127    10126    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.