Skip to content

[O2B-1460] Filtering on Runs per LHC Period overview page#1957

Merged
xsalonx merged 27 commits into
mainfrom
xsalonx/filtering/O2B-1460/runs-per-lhc-period
Aug 20, 2025
Merged

[O2B-1460] Filtering on Runs per LHC Period overview page#1957
xsalonx merged 27 commits into
mainfrom
xsalonx/filtering/O2B-1460/runs-per-lhc-period

Conversation

@xsalonx

@xsalonx xsalonx commented Aug 6, 2025

Copy link
Copy Markdown
Collaborator

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • Add filters to Runs Per LHC Period ovreview page: by run, fill, start, stop, L3/dipole, INEL values

Notable changes for developers:

  • Refactor RunsPerLhcPeriodModel to use LHC Period ID instead of its name

Changes made to the database:

  • NA

@xsalonx xsalonx self-assigned this Aug 6, 2025
@codecov

codecov Bot commented Aug 6, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 55 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.75%. Comparing base (e40cbb4) to head (c6b68d0).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...Runs/RunPerPeriod/RunsPerLhcPeriodOverviewModel.js 0.00% 30 Missing ⚠️
.../Runs/RunPerPeriod/RunsPerLhcPeriodOverviewPage.js 0.00% 23 Missing ⚠️
lib/public/views/Runs/RunsModel.js 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1957      +/-   ##
==========================================
- Coverage   45.81%   45.75%   -0.06%     
==========================================
  Files        1019     1019              
  Lines       16863    16885      +22     
  Branches     3041     3038       -3     
==========================================
+ Hits         7725     7726       +1     
- Misses       9138     9159      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@xsalonx

xsalonx commented Aug 6, 2025

Copy link
Copy Markdown
Collaborator Author

To be merged after #1955

@xsalonx xsalonx marked this pull request as ready for review August 6, 2025 12:50
@xsalonx xsalonx requested a review from graduta as a code owner August 6, 2025 12:50
@xsalonx xsalonx changed the title [O2B-1460] Filtering on Runs per LHC Period page [O2B-1460] Filtering on Runs per LHC Period overview page Aug 12, 2025

@graduta graduta left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that the runs request already contains both the lhcPeriodId and lhcPeriodName and on top of that the table bug in which the request for runs and now for lhcPeriodStatistics are duplicated, is it worth doing a statistics request here on load?
I cannot see any other data being used from this request that would be displayed on the page

Comment thread lib/public/views/Runs/RunPerPeriod/RunsPerLhcPeriodOverviewPage.js Outdated
@xsalonx xsalonx requested a review from graduta August 12, 2025 12:22
graduta
graduta previously approved these changes Aug 19, 2025
graduta
graduta previously approved these changes Aug 19, 2025
graduta
graduta previously approved these changes Aug 19, 2025
@xsalonx xsalonx merged commit ef9ca8a into main Aug 20, 2025
54 of 58 checks passed
@xsalonx xsalonx deleted the xsalonx/filtering/O2B-1460/runs-per-lhc-period branch August 20, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants