Skip to content

[O2B-1471] Remove unnecessary PdpBeamType parameter from url#1958

Merged
xsalonx merged 25 commits into
mainfrom
xsalonx/fix/beam-types
Sep 19, 2025
Merged

[O2B-1471] Remove unnecessary PdpBeamType parameter from url#1958
xsalonx merged 25 commits into
mainfrom
xsalonx/fix/beam-types

Conversation

@xsalonx

@xsalonx xsalonx commented Aug 6, 2025

Copy link
Copy Markdown
Collaborator

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • NA

Notable changes for developers:

  • Unify the way how PDP beam type is retrieved for LHC periods, data passes and simulation passes, and how it is used on frontend
  • Removed pdpBeamType parameter form frontend URLs
  • Change LHC Periods filter from beamTypes to pdpBeamTypes

Changes made to the database:

  • NA

@xsalonx xsalonx self-assigned this Aug 6, 2025
@xsalonx xsalonx added bug Something isn't working frontend backend labels Aug 6, 2025
@codecov

codecov Bot commented Aug 6, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 20.45455% with 35 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.70%. Comparing base (d3eccf0) to head (ffa1065).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...uns/RunPerDataPass/RunsPerDataPassOverviewModel.js 0.00% 7 Missing ⚠️
...ews/lhcPeriods/Overview/LhcPeriodsOverviewModel.js 0.00% 6 Missing ⚠️
...Runs/Overview/FixedPdpBeamTypeRunsOverviewModel.js 0.00% 5 Missing ⚠️
...Runs/RunPerPeriod/RunsPerLhcPeriodOverviewModel.js 0.00% 4 Missing ⚠️
...mulationPass/RunsPerSimulationPassOverviewModel.js 0.00% 4 Missing ⚠️
...olumns/getInelasticInteractionRateActiveColumns.js 0.00% 3 Missing ⚠️
...Runs/RunPerDataPass/RunsPerDataPassOverviewPage.js 0.00% 2 Missing ⚠️
...hcPeriods/ActiveColumns/lhcPeriodsActiveColumns.js 0.00% 2 Missing ⚠️
.../Runs/RunPerPeriod/RunsPerLhcPeriodOverviewPage.js 0.00% 1 Missing ⚠️
lib/public/views/Runs/RunsModel.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1958      +/-   ##
==========================================
- Coverage   45.71%   45.70%   -0.01%     
==========================================
  Files        1019     1020       +1     
  Lines       16916    16924       +8     
  Branches     3046     3048       +2     
==========================================
+ Hits         7733     7735       +2     
- Misses       9183     9189       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@xsalonx xsalonx changed the title PDP Beam Types dependent active column fixes [O2B-1471] PDP Beam Types dependent active column fixes Aug 20, 2025
@xsalonx xsalonx changed the title [O2B-1471] PDP Beam Types dependent active column fixes [O2B-1471] Remove unnecessary PdpBeamType parameter from url Aug 20, 2025
@xsalonx xsalonx marked this pull request as ready for review September 2, 2025 13:26
@xsalonx xsalonx requested a review from graduta as a code owner September 2, 2025 13:26
@xsalonx xsalonx merged commit 161dfae into main Sep 19, 2025
38 of 41 checks passed
@xsalonx xsalonx deleted the xsalonx/fix/beam-types branch September 19, 2025 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend bug Something isn't working frontend

Development

Successfully merging this pull request may close these issues.

2 participants