[PWGCF] FemtoUniverse -- Add helicity angle analysis in lambda decay.#11254
Conversation
a-m-andrushko
requested review from
alibuild,
ariedel-cern,
glromane,
lauraser,
lgraczykCern,
otonvd,
prchakra,
saganatt,
shouqiye,
victor-gonzalez and
zchochul
as code owners
|
O2 linter results: ❌ 5 errors, |
github-actions
Bot
changed the title
|
Hi @vkucera just to let you know about the @a-m-andrushko the |
|
@victor-gonzalez, could you review and accept the changes, please? |
Both issues have been fixed. The problem is that the PR branch is 1770 commits behind the upstream master. |
Oh! Wow! |
@victor-gonzalez, indeed, it was my mistake, I did not synchronise the branch before committing, sorry; now there are no issues with MegaLinter. |
| auto pdgDB = TDatabasePDG::Instance(); | ||
| auto protonMass = pdgDB->GetParticle(confPDGCodePositiveChild)->Mass(); | ||
| auto pionMass = pdgDB->GetParticle(confPDGCodeNegativeChild)->Mass(); |
There was a problem hiding this comment.
Is there any reason for, now that the O2DatabasePDG service has been instantiated L.44, not using it for getting the particle masses as pdg->Mass(confPDGCodePositiveChild) for instance?
a-m-andrushko
force-pushed
the
cosine_theta
branch
from
6bb2d15 to
117b5e7
Compare
|
@a-m-andrushko You did not rebase properly. You have unresolved merge conflicts in the commit. |
@vkucera, I cannot see this problem from my side, where can you see conflicts? Also, I might not have rebased properly indeed, because the errors that I had been facing before the rebase still remain. I did 'git fetch upstream' and 'git rebase upstream/master'. |
|
Now your branch is again very obsolete. |
@vkucera, I rebased properly this time, MegaLinter errors are fixed; when it comes to O2 linter, these errors are a bit complex and will be fixed in future PRs. |
5 participants
Helicity angle theta is calculated between lambda and its daughter (proton) in PRF of lambda.