[Common,PWGUD,PWGLF,PWGHF] DPL Analysis: fix for reworked column getters#11731
Closed
aalkin wants to merge 5 commits into
Closed
[Common,PWGUD,PWGLF,PWGHF] DPL Analysis: fix for reworked column getters#11731aalkin wants to merge 5 commits into
aalkin wants to merge 5 commits into
Conversation
aalkin
requested review from
a team,
alibuild,
ddobrigk,
iarsene,
jgrosseo and
ktf
as code owners
|
O2 linter results: ❌ 173 errors, |
github-actions
Bot
changed the title
aalkin
changed the title
github-actions
Bot
changed the title
aalkin
requested review from
abmodak,
dmallick2,
ercolessi,
fmazzasc,
gbencedi,
maciacco,
romainschotter,
skundu692 and
smaff92
as code owners
aalkin
changed the title
github-actions
Bot
changed the title
aalkin
requested review from
NicoleBastid,
apalasciano,
deepathoms,
fcatalan92,
fcolamar,
fgrosa,
gluparel,
hahassan7,
jpxrk,
mfaggin,
mmazzilli,
vkucera and
zhangbiao-phy
as code owners
aalkin
changed the title
vkucera
previously approved these changes
Jun 23, 2025
rolavick
previously approved these changes
Jun 23, 2025
Member
Author
Collaborator
Thanks @aalkin for the clarification. I would keep the PR as a draft then until all commits are pushed. |
Member
Author
|
The amount of changes required is too large for a one-off PR. It will be done in a smaller, manageable steps. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to changes in how the column getters work made in AliceO2Group/AliceO2#14421 the single-valued columns return an rvalue, while fixed- and variable-size array columns return a span. This requires some small changed throughout O2Physics where these kinds of columns are accessed.