[PWGJE] Addition of bins for vertex finding efficiency and vertex reconstruction corrections#12638
Closed
Archita-Dash wants to merge 6 commits into
Closed
[PWGJE] Addition of bins for vertex finding efficiency and vertex reconstruction corrections#12638Archita-Dash wants to merge 6 commits into
Archita-Dash wants to merge 6 commits into
Conversation
… the vertex reconstruction bias and verter reconstruction efficiency
Archita-Dash
requested review from
alibuild,
fjonasALICE,
maoyx,
mfasDa,
mhemmer-cern and
nzardosh
as code owners
|
O2 linter results: ❌ 31 errors, |
github-actions
Bot
changed the title
Please consider the following formatting changes to AliceO2Group#12638
Contributor
Author
|
Update: Closing this PR because after discussing with Nima, we figured out that the lumi producer task itself needs refactoring in the jet framework and that for my correction factors estimation for my analysis, it is easiest and simplest to include a BC loop in my analysis which has now been implemented in my full jet task and the merged PR can be found here: #12721 Archita. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @nzardosh ,
this commit includes additional bins before and after the Vtx Z cuts in order to calculate
Both can be obtained directly with data (reconstructed level). I tested locally with a small file and this seems to work as desired. I've attached here the histogram from my local test. As I mentioned the other day at the JP PAG meeting, I personally use Sel8Full+IsGoodVtxZ event selection for my analysis; however I am aware that other charged jet analyses are using sel8. Therefore I have included the corresponding bins for sel8 for the sake of completeness.
Cheers,
Archita