-
Notifications
You must be signed in to change notification settings - Fork 665
[PWGLF] add new table for Hypertiton collision ID #12824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 8 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
285877c
add new table for Hypertiton collision ID
82e1353
Merge branch 'AliceO2Group:master' into master
blacwovie 729ffd4
Please consider the following formatting changes
alibuild b1d7e35
Merge pull request #23 from alibuild/alibot-cleanup-12824
blacwovie 45b1c20
Update hyperRecoTask.cxx
blacwovie 3748dd6
Please consider the following formatting changes
alibuild b8b716b
Merge pull request #24 from alibuild/alibot-cleanup-12824
blacwovie f9aa132
Update hyperRecoTask.cxx
blacwovie 3e87284
Update hyperRecoTask.cxx
blacwovie f7a4d89
Please consider the following formatting changes
alibuild 7326892
Merge pull request #25 from alibuild/alibot-cleanup-12824
blacwovie a29bf47
Update hyperRecoTask.cxx
blacwovie 75370ed
Update hyperRecoTask.cxx
blacwovie File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please check the missing parantheses here in the cast statement
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, I'm bit confused. In line 413, I would like to ask whether the cast to int16_t here is applied only to heTrack.tpcNClsFindable(), or to the entire expression heTrack.tpcNClsFindable() - heTrack.tpcNClsFindableMinusPID().
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if it's the former then I made a mistake to cast entire expression to int16_t
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I disabled the auto-merge so that you can make the change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done. Thank you Mario:)