Skip to content

[Common] Fix includes#12833

Merged
ddobrigk merged 26 commits into
AliceO2Group:masterfrom
vkucera:common-headers
Sep 8, 2025
Merged

[Common] Fix includes#12833
ddobrigk merged 26 commits into
AliceO2Group:masterfrom
vkucera:common-headers

Conversation

@vkucera

@vkucera vkucera commented Sep 2, 2025

Copy link
Copy Markdown
Collaborator

Clean up header dependencies and fix related stuff.

  • Apply IWYU with clang-tidy.
  • Fix include style with format_includes.awk.
  • Fix incomplete header paths.
  • Flag transitive includes that should be removed asap.
    • Common/DataModel/EventSelection.h
    • Common/DataModel/PIDResponse.h
    • Common/Tools/TrackTuner.h
    • Common/TableProducer/mftmchMatchingML.cxx
    • Common/Tasks/qaMuon.cxx
    • Common/Tasks/trackqa.cxx
  • Fix wrong, missing or misplaced header guards.
    • Common/DataModel/MatchMFTMuonData.h
    • Common/DataModel/MatchMFTFT0.h
    • Common/Tools/EventSelectionModule.h
    • Common/Tools/Multiplicity/MultModule.h
    • Common/Tools/PID/pidTPCModule.h
    • Common/Tools/timestampModule.h
  • Remove comments between include blocks (to enable automatic sorting and grouping).
  • Fix misplaced includes.
    • Common/TableProducer/match-mft-mch-data-mc.cxx
    • Common/TableProducer/match-mft-mch-data.cxx
    • Common/Tasks/checkDataModel.cxx
    • Common/Tools/EventSelectionModule.h
  • Add IWYU pragmas for special cases.
    • Common/Core/CollisionAssociation.cxx
    • Common/LegacyDataQA/pcmRun2.cxx
    • Common/TableProducer/PID/pidTPCBase.h
    • Common/Tasks/qaMuon.cxx
    • Common/Tools/PID/pidTPCModule.h
  • Fix missing std::
    • Common/TableProducer/match-mft-mch-data.cxx
    • Common/TableProducer/match-mft-mch-data-mc.cxx

@github-actions github-actions Bot changed the title IWYU [Common] IWYU Sep 2, 2025
@vkucera vkucera mentioned this pull request Sep 2, 2025
@github-actions

github-actions Bot commented Sep 2, 2025

Copy link
Copy Markdown

O2 linter results: ❌ 2413 errors, ⚠️ 0 warnings, 🔕 113 disabled

@vkucera vkucera changed the title [Common] IWYU [Common] Fix header includes Sep 3, 2025
@vkucera vkucera changed the title [Common] Fix header includes [Common] Fix includes Sep 3, 2025
@vkucera vkucera marked this pull request as ready for review September 3, 2025 15:23

@ddobrigk ddobrigk left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot!

@ddobrigk ddobrigk merged commit d3c2e47 into AliceO2Group:master Sep 8, 2025
11 of 13 checks passed
@vkucera vkucera deleted the common-headers branch September 8, 2025 13:57
jinhyunni pushed a commit to jinhyunni/O2Physics that referenced this pull request Oct 11, 2025
ThePhDane pushed a commit to ThePhDane/O2Physics that referenced this pull request Nov 3, 2025
jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants