Skip to content

[Common] EventPlane: adding shift correction#12967

Merged
strogolo merged 6 commits into
AliceO2Group:masterfrom
jikim1290:ep2
Oct 6, 2025
Merged

[Common] EventPlane: adding shift correction#12967
strogolo merged 6 commits into
AliceO2Group:masterfrom
jikim1290:ep2

Conversation

@jikim1290

@jikim1290 jikim1290 commented Sep 12, 2025

Copy link
Copy Markdown
Contributor

@github-actions

github-actions Bot commented Sep 12, 2025

Copy link
Copy Markdown

O2 linter results: ❌ 115 errors, ⚠️ 0 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title [Commom/EventPlane] adding shift correction [Common] [Commom/EventPlane] adding shift correction Sep 12, 2025
jikim1290 added a commit to jikim1290/O2Physics that referenced this pull request Sep 12, 2025
Please consider the following formatting changes to AliceO2Group#12967
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for a1d3e47 at 2025-09-12 06:25:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/12967-slc9_x86-64/0/Common/TableProducer/qVectorsTable.cxx:168:22: error: 'string' was not declared in this scope
/sw/SOURCES/O2Physics/12967-slc9_x86-64/0/Common/TableProducer/qVectorsTable.cxx:168:34: error: template argument 1 is invalid
/sw/SOURCES/O2Physics/12967-slc9_x86-64/0/Common/TableProducer/qVectorsTable.cxx:168:34: error: template argument 3 is invalid
/sw/SOURCES/O2Physics/12967-slc9_x86-64/0/Common/TableProducer/qVectorsTable.cxx:168:34: error: template argument 4 is invalid
/sw/SOURCES/O2Physics/12967-slc9_x86-64/0/Common/TableProducer/qVectorsTable.cxx:168:34: error: template argument 5 is invalid
/sw/SOURCES/O2Physics/12967-slc9_x86-64/0/Common/TableProducer/qVectorsTable.cxx:168:8: error: '<expression error>' in namespace 'std' does not name a type
/sw/SOURCES/O2Physics/12967-slc9_x86-64/0/Common/TableProducer/qVectorsTable.cxx:187:27: error: 'useDetector' was not declared in this scope
/sw/SOURCES/O2Physics/12967-slc9_x86-64/0/Common/TableProducer/qVectorsTable.cxx:193:25: error: 'useDetector' was not declared in this scope
/sw/SOURCES/O2Physics/12967-slc9_x86-64/0/Common/TableProducer/qVectorsTable.cxx:366:33: error: 'useDetector' was not declared in this scope
/sw/SOURCES/O2Physics/12967-slc9_x86-64/0/Common/TableProducer/qVectorsTable.cxx:435:32: error: 'useDetector' was not declared in this scope
/sw/SOURCES/O2Physics/12967-slc9_x86-64/0/Common/TableProducer/qVectorsTable.cxx:482:29: error: 'useDetector' was not declared in this scope
/sw/SOURCES/O2Physics/12967-slc9_x86-64/0/Common/TableProducer/qVectorsTable.cxx:728:9: error: 'useDetector' was not declared in this scope
/sw/SOURCES/O2Physics/12967-slc9_x86-64/0/Common/TableProducer/qVectorsTable.cxx:730:9: error: 'useDetector' was not declared in this scope
/sw/SOURCES/O2Physics/12967-slc9_x86-64/0/Common/TableProducer/qVectorsTable.cxx:732:9: error: 'useDetector' was not declared in this scope
/sw/SOURCES/O2Physics/12967-slc9_x86-64/0/Common/TableProducer/qVectorsTable.cxx:734:9: error: 'useDetector' was not declared in this scope
/sw/SOURCES/O2Physics/12967-slc9_x86-64/0/Common/TableProducer/qVectorsTable.cxx:736:9: error: 'useDetector' was not declared in this scope
/sw/SOURCES/O2Physics/12967-slc9_x86-64/0/Common/TableProducer/qVectorsTable.cxx:738:9: error: 'useDetector' was not declared in this scope
/sw/SOURCES/O2Physics/12967-slc9_x86-64/0/Common/TableProducer/qVectorsTable.cxx:740:9: error: 'useDetector' was not declared in this scope
/sw/SOURCES/O2Physics/12967-slc9_x86-64/0/Common/TableProducer/qVectorsTable.cxx:763:9: error: 'useDetector' was not declared in this scope
/sw/SOURCES/O2Physics/12967-slc9_x86-64/0/Common/TableProducer/qVectorsTable.cxx:765:9: error: 'useDetector' was not declared in this scope
/sw/SOURCES/O2Physics/12967-slc9_x86-64/0/Common/TableProducer/qVectorsTable.cxx:767:9: error: 'useDetector' was not declared in this scope
ninja: build stopped: subcommand failed.

Full log here.

jikim1290 added a commit to jikim1290/O2Physics that referenced this pull request Sep 12, 2025
Please consider the following formatting changes to AliceO2Group#12967
@vkucera vkucera changed the title [Common] [Commom/EventPlane] adding shift correction [Common/EventPlane] adding shift correction Sep 15, 2025
@vkucera vkucera changed the title [Common/EventPlane] adding shift correction [Common] EventPlane: adding shift correction Sep 15, 2025

@vkucera vkucera left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dear @jikim1290 , your changes are reverting my fixes made in #12833. Please remove your changes and be more careful when you rebase your branch.
Also please try to avoid invalid PR tags and typos in your PR titles.
It would also be more useful if you added more details in the description about what your PR does.

Comment thread Common/DataModel/Qvectors.h Outdated
Comment thread Common/TableProducer/qVectorsTable.cxx Outdated
Comment thread Common/TableProducer/qVectorsTable.cxx Outdated
Comment thread Common/Tasks/qVectorsCorrection.cxx Outdated
jikim1290 added a commit to jikim1290/O2Physics that referenced this pull request Sep 23, 2025
Please consider the following formatting changes to AliceO2Group#12967
@strogolo

Copy link
Copy Markdown
Collaborator

Dear @jikim1290
thanks a lot for your PR and you don't need to add extra description since the content of this PR was deeply discussed at the DPG AOT meeting. So people are informed about this technical development and we all agree with this proposal.
The only doubt I have is related to the change at lines 100-101 in qVectorsTable.cxx, precisely where you are adding
Configurable<bool> cfgShiftCorr{"cfgShiftCorr", false, "configurable flag for shift correction"}; Configurable<std::string> cfgShiftPath{"cfgShiftPath", "", "CCDB path for shift correction"};
This means that we would have an additional object to upload to an additional path and to configure it properly, so increasing the possibility of errors, missing objects and misconfigurations.

  1. Is it the only possible solution to duplicate adding a new path?
  2. Have you checked that it is possible to run the frame even when there is not this object? Because there datasets for which we don't and will not have this correction.
  3. I'd like to hear the opinion also from @ddobrigk

Cheers,
Stefano

Comment thread Common/TableProducer/qVectorsTable.cxx Outdated
Comment thread Common/TableProducer/qVectorsTable.cxx Outdated
Comment thread Common/TableProducer/qVectorsTable.cxx Outdated
Please consider the following formatting changes to AliceO2Group#12967
@jikim1290

Copy link
Copy Markdown
Contributor Author

@strogolo this correction is implemented after applying previous full corrections. The input for shift correction is different from others and can not be done at the same stage. Therefore I think it is better to have independent configuration.
Please provide comments or merge this

@strogolo strogolo merged commit bb36e04 into AliceO2Group:master Oct 6, 2025
15 of 16 checks passed
jinhyunni pushed a commit to jinhyunni/O2Physics that referenced this pull request Oct 11, 2025
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
ArkaprabhaSaha001 pushed a commit to ArkaprabhaSaha001/O2Physics that referenced this pull request Oct 21, 2025
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
ThePhDane pushed a commit to ThePhDane/O2Physics that referenced this pull request Nov 3, 2025
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025
Co-authored-by: ALICE Action Bot <alibuild@cern.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

5 participants