Skip to content

[PWGCF] adding shift correction for event plane#13183

Closed
jikim1290 wants to merge 11 commits into
AliceO2Group:masterfrom
jikim1290:cf2
Closed

[PWGCF] adding shift correction for event plane#13183
jikim1290 wants to merge 11 commits into
AliceO2Group:masterfrom
jikim1290:cf2

Conversation

@jikim1290

@jikim1290 jikim1290 commented Sep 30, 2025

Copy link
Copy Markdown
Contributor

adding shift correction for event plane
adding scalar product method

@github-actions github-actions Bot added the pwgcf label Sep 30, 2025
@github-actions

github-actions Bot commented Sep 30, 2025 •
edited
Loading

Copy link
Copy Markdown

O2 linter results: ❌ 16 errors, ⚠️ 0 warnings, 🔕 0 disabled

@alibuild alibuild mentioned this pull request Sep 30, 2025
Merged
jikim1290 added a commit to jikim1290/O2Physics that referenced this pull request Sep 30, 2025
@jikim1290
Merge pull request #154 from alibuild/alibot-cleanup-13183
0b7d164 
Please consider the following formatting changes to AliceO2Group#13183
@alibuild alibuild mentioned this pull request Sep 30, 2025
Merged
jikim1290 added a commit to jikim1290/O2Physics that referenced this pull request Sep 30, 2025
@jikim1290
Merge pull request #155 from alibuild/alibot-cleanup-13183
7ffb7c2 
Please consider the following formatting changes to AliceO2Group#13183
@alibuild alibuild mentioned this pull request Sep 30, 2025
Merged
jikim1290 added a commit to jikim1290/O2Physics that referenced this pull request Sep 30, 2025
@jikim1290
Merge pull request #156 from alibuild/alibot-cleanup-13183
bb8fcb4 
Please consider the following formatting changes to AliceO2Group#13183
@alibuild alibuild mentioned this pull request Sep 30, 2025
Merged
jikim1290 added a commit to jikim1290/O2Physics that referenced this pull request Sep 30, 2025
@jikim1290
Merge pull request #157 from alibuild/alibot-cleanup-13183
81887d1 
Please consider the following formatting changes to AliceO2Group#13183
@victor-gonzalez

victor-gonzalez commented Sep 30, 2025

Copy link
Copy Markdown
Collaborator

Please, in the new introduced code, follow linter recommendations

@alibuild alibuild mentioned this pull request Oct 1, 2025
Closed
@alibuild

alibuild commented Oct 1, 2025

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 9201a6a at 2025-10-01 11:36:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/13183-slc9_x86-64/0/PWGCF/JCorran/Tasks/jEPFlowAnalysis.cxx:186:26: error: comparison of integer expressions of different signedness: 'uint' {aka 'unsigned int'} and 'int' [-Werror=sign-compare]
ninja: build stopped: subcommand failed.

Full log here.

@jikim1290

jikim1290 commented Oct 1, 2025

Copy link
Copy Markdown
Contributor Author

Let me close this first and the other will open a new one

@jikim1290 jikim1290 closed this Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner
@victor-gonzalez victor-gonzalez Awaiting requested review from victor-gonzalez victor-gonzalez is a code owner
@zchochul zchochul Awaiting requested review from zchochul
@lgraczykCern lgraczykCern Awaiting requested review from lgraczykCern
@prchakra prchakra Awaiting requested review from prchakra
@lauraser lauraser Awaiting requested review from lauraser lauraser is a code owner
@ariedel-cern ariedel-cern Awaiting requested review from ariedel-cern
@otonvd otonvd Awaiting requested review from otonvd
@shouqiye shouqiye Awaiting requested review from shouqiye shouqiye is a code owner
@glromane glromane Awaiting requested review from glromane

Assignees

No one assigned

Labels

pwgcf

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jikim1290 @victor-gonzalez @alibuild