Skip to content

[PWGHF] Add script to check injected signal in PbPb embedded MC#13235

Merged
fgrosa merged 6 commits into
AliceO2Group:masterfrom
fchinu:check_injection
Oct 8, 2025
Merged

[PWGHF] Add script to check injected signal in PbPb embedded MC#13235
fgrosa merged 6 commits into
AliceO2Group:masterfrom
fchinu:check_injection

Conversation

@fchinu

@fchinu fchinu commented Oct 4, 2025

Copy link
Copy Markdown
Contributor

@fgrosa @stefanopolitano here is the task I used to check our PbPb MC production. Let me know if you have any suggestion on other features to check!

@github-actions github-actions Bot added the pwghf PWG-HF label Oct 4, 2025
@github-actions

github-actions Bot commented Oct 4, 2025 •
edited
Loading

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 4 disabled

@github-actions github-actions Bot changed the title Add script to check injected signal in PbPb embedded MC [PWGHF] Add script to check injected signal in PbPb embedded MC Oct 4, 2025
@vkucera vkucera marked this pull request as draft October 4, 2025 16:40
vkucera
vkucera requested changes Oct 4, 2025
View reviewed changes

@vkucera vkucera left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the errors before marking as "ready for review".

Comment thread PWGHF/Tasks/CMakeLists.txt
@alibuild

alibuild commented Oct 4, 2025

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 8924407 at 2025-10-04 20:44:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/13235-slc9_x86-64/0/PWGHF/Tasks/taskMcInjection.cxx:167:9: error: unused variable 'splitColls' [-Werror=unused-variable]
ninja: build stopped: subcommand failed.

Full log here.

vkucera
vkucera reviewed Oct 6, 2025
View reviewed changes
Comment thread PWGHF/Tasks/taskMcInjection.cxx Outdated
vkucera
vkucera reviewed Oct 6, 2025
View reviewed changes
Comment thread PWGHF/Tasks/taskMcInjection.cxx Outdated
vkucera
vkucera reviewed Oct 6, 2025
View reviewed changes
Comment thread PWGHF/Tasks/taskMcInjection.cxx Outdated
@fchinu

fchinu commented Oct 6, 2025

Copy link
Copy Markdown
Contributor Author

Hi @vkucera, thanks for your suggestions! I have addressed them

@fchinu fchinu marked this pull request as ready for review October 6, 2025 12:19
@vkucera

vkucera commented Oct 6, 2025

Copy link
Copy Markdown
Collaborator

Hi @vkucera, thanks for your suggestions! I have addressed them

Thanks @fchinu !

@fgrosa

fgrosa commented Oct 8, 2025

Copy link
Copy Markdown
Collaborator

Thanks a lot @fchinu, very useful! I am merging

@fgrosa fgrosa merged commit 34e0e1d into AliceO2Group:master Oct 8, 2025
13 checks passed
ArkaprabhaSaha001 pushed a commit to ArkaprabhaSaha001/O2Physics that referenced this pull request Oct 21, 2025
@fchinu
[PWGHF] Add script to check injected signal in PbPb embedded MC (Alic…
5aa6574 
…eO2Group#13235)
ThePhDane pushed a commit to ThePhDane/O2Physics that referenced this pull request Nov 3, 2025
@fchinu @ThePhDane
[PWGHF] Add script to check injected signal in PbPb embedded MC (Alic…
2c4aea7 
…eO2Group#13235)
jloemker pushed a commit to jloemker/O2Physics that referenced this pull request Nov 11, 2025
@fchinu @jloemker
[PWGHF] Add script to check injected signal in PbPb embedded MC (Alic…
eced538 
…eO2Group#13235)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkucera vkucera vkucera approved these changes
@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner
@fcolamar fcolamar Awaiting requested review from fcolamar fcolamar is a code owner
@fgrosa fgrosa Awaiting requested review from fgrosa fgrosa is a code owner
@fcatalan92 fcatalan92 Awaiting requested review from fcatalan92 fcatalan92 is a code owner
@mfaggin mfaggin Awaiting requested review from mfaggin mfaggin is a code owner
@mmazzilli mmazzilli Awaiting requested review from mmazzilli mmazzilli is a code owner
@deepathoms deepathoms Awaiting requested review from deepathoms deepathoms is a code owner
@NicoleBastid NicoleBastid Awaiting requested review from NicoleBastid NicoleBastid is a code owner
@hahassan7 hahassan7 Awaiting requested review from hahassan7 hahassan7 is a code owner
@jpxrk jpxrk Awaiting requested review from jpxrk jpxrk is a code owner
@apalasciano apalasciano Awaiting requested review from apalasciano apalasciano is a code owner
@zhangbiao-phy zhangbiao-phy Awaiting requested review from zhangbiao-phy zhangbiao-phy is a code owner
@gluparel gluparel Awaiting requested review from gluparel gluparel is a code owner
@stefanopolitano stefanopolitano Awaiting requested review from stefanopolitano stefanopolitano is a code owner

Assignees

No one assigned

Labels

pwghf PWG-HF

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fchinu @alibuild @vkucera @fgrosa