[MCH] added review suggestions

Author: aferrero2707

Modules/MUON/MCH/include/MCH/DecodingPostProcessing.h

@@ -73,7 +73,7 @@ class DecodingPostProcessing : public ReferenceComparatorTask
   static std::string hbPacketsSourceName() { return "hbpackets"; }
   static std::string syncStatusSourceName() { return "syncstatus"; }
 
-  TH1* getHistogram(std::string plotName);
+  TH1* getHistogram(std::string_view plotName);
 
   bool mFullHistos{ false };
   bool mEnableLastCycleHistos{ false };

Modules/MUON/MCH/include/MCH/DigitsPostProcessing.h

@@ -63,7 +63,7 @@ class DigitsPostProcessing : public ReferenceComparatorTask
   static std::string orbitsSourceName() { return "orbits"; }
   static std::string orbitsSignalSourceName() { return "orbits_signal"; }
 
-  TH1* getHistogram(std::string plotName);
+  TH1* getHistogram(std::string_view plotName);
 
   bool mFullHistos{ false };
   bool mEnableLastCycleHistos{ false };

Modules/MUON/MCH/include/MCH/PreclustersPostProcessing.h

@@ -72,7 +72,7 @@ class PreclustersPostProcessing : public ReferenceComparatorTask
   static std::string clusterChargeSourceName() { return "clcharge"; }
   static std::string clusterSizeSourceName() { return "clsize"; }
 
-  TH1* getHistogram(std::string plotName);
+  TH1* getHistogram(std::string_view plotName);
 
   bool mFullHistos{ false };
   bool mEnableLastCycleHistos{ false };

Modules/MUON/MCH/include/MCH/QualityAggregatorTask.h

@@ -12,7 +12,7 @@
 ///
 /// \file    QualityAggregatorTask.h
 /// \author  Andrea Ferrero andrea.ferrero@cern.ch
-/// \brief   Post-processing of the MCH pre-clusters
+/// \brief   Post-processing of the MCH summary qualities
 /// \since   21/06/2022
 ///
 

Modules/MUON/MCH/src/DecodingPostProcessing.cxx

@@ -286,7 +286,7 @@ void DecodingPostProcessing::updateSyncStatusHistos(Trigger t, repository::Datab
 
 //_________________________________________________________________________________________
 
-TH1* DecodingPostProcessing::getHistogram(std::string plotName)
+TH1* DecodingPostProcessing::getHistogram(std::string_view plotName)
 {
   TH1* result{ nullptr };
   for (auto hist : mHistogramsAll) {

Modules/MUON/MCH/src/DigitsPostProcessing.cxx

@@ -348,7 +348,7 @@ void DigitsPostProcessing::updateOrbitHistos(Trigger t, repository::DatabaseInte
 
 //_________________________________________________________________________________________
 
-TH1* DigitsPostProcessing::getHistogram(std::string plotName)
+TH1* DigitsPostProcessing::getHistogram(std::string_view plotName)
 {
   TH1* result{ nullptr };
   for (auto hist : mHistogramsAll) {

Modules/MUON/MCH/src/Helpers.cxx

@@ -184,15 +184,6 @@ int getDEFromIndex(int index)
       if (deId < 0) {
         deId = lMax + (nDEhc - indexInHalfChamber);
       }
-      /*if (indexInHalfChamber > nDEqc) {
-        // the DE is in the lower half of the chamber
-        std::cout << "DE on lower R side, indexInHalfChamber=" << indexInHalfChamber << " nDEqc=" << nDEqc << std::endl;
-        deId = lMax + (nDEhc - indexInHalfChamber);
-      } else {
-        // the DE is in the upper half of the chamber
-        std::cout << "DE on upper R side, indexInHalfChamber=" << indexInHalfChamber << " nDEqc=" << nDEqc << std::endl;
-        deId = lMin - indexInHalfChamber - 1;
-      }*/
     }
 
     deId += (chamber + 1) * 100;
@@ -245,7 +236,7 @@ int getSolarIndex(int solarId)
   try {
     return m.at(solarId);
   } catch (const std::exception&) {
-    ILOG(Error, Support) << "Invalid Solar Id: " << solarId;
+    ILOG(Error, Support) << "Invalid Solar Id: " << solarId << ENDM;
   }
   return -1;
 }
@@ -256,18 +247,11 @@ int getSolarIdFromIndex(int index)
   try {
     return v.at(index);
   } catch (const std::exception&) {
-    ILOG(Error, Support) << "Invalid Solar Index: " << index;
+    ILOG(Error, Support) << "Invalid Solar Index: " << index << ENDM;
   }
   return -1;
 }
-/*
-constexpr int getNumSolar()
-{
-  //static std::vector<uint32_t> v = buildSolarIndexToSolarIdMap();
-  //return v.size();
-  return 624;
-}
-*/
+
 int getNumSolarPerChamber(int chamberId)
 {
   static std::array<uint32_t, 10> v{ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0 };
@@ -567,8 +551,6 @@ void addChamberDelimitersToSolarHistogram(TH1* h, float xmin, float xmax)
     h->GetListOfFunctions()->Add(delimiter);
   }
 
-  // addChamberLabelsForSolar(h);
-
   // draw x-axis labels
   /*float xMin{ 0 };
   float xMax{ 0 };

Modules/MUON/MCH/src/PreclustersPostProcessing.cxx

@@ -307,7 +307,7 @@ void PreclustersPostProcessing::updateClusterSizeHistos(Trigger t, repository::D
 
 //_________________________________________________________________________________________
 
-TH1* PreclustersPostProcessing::getHistogram(std::string plotName)
+TH1* PreclustersPostProcessing::getHistogram(std::string_view plotName)
 {
   TH1* result{ nullptr };
   for (auto hist : mHistogramsAll) {

Modules/MUON/MCH/src/QualityAggregatorTask.cxx

@@ -12,7 +12,7 @@
 ///
 /// \file    QualityAggregatorTask.cxx
 /// \author  Andrea Ferrero andrea.ferrero@cern.ch
-/// \brief   Post-processing of the MCH pre-clusters
+/// \brief   Post-processing of the MCH summary qualities
 /// \since   21/06/2022
 ///