ITS decoding error check (#1903)

* deadchip

* camel case for phi and eta bins

* Decoding Error for ErrId 10

* DecodingErrorID10 bug

* bug for DecodingErrorID10

* bug for DecodingErrorId10

---------

Co-authored-by: JianLIUhep <jian@cern.ch>
Co-authored-by: iravasen <ivan.ravasenga@cern.ch>

Author: 3 people

Modules/ITS/include/ITS/ITSDecodingErrorCheck.h

@@ -41,7 +41,7 @@ class ITSDecodingErrorCheck : public o2::quality_control::checker::CheckInterfac
   // Override interface
   Quality check(std::map<std::string, std::shared_ptr<MonitorObject>>* moMap) override;
   void beautify(std::shared_ptr<MonitorObject> mo, Quality checkResult = Quality::Null) override;
-  std::vector<int> vDecErrorLimits, vListErrorIdBad, vListErrorIdMedium;
+  std::vector<int> vListErrorIdBad, vListErrorIdMedium;
   bool doFlatCheck = false;
   o2::itsmft::GBTLinkDecodingStat statistics;
 
@@ -58,6 +58,8 @@ class ITSDecodingErrorCheck : public o2::quality_control::checker::CheckInterfac
 
       if constexpr (std::is_same_v<T, int>) {
         result.push_back(std::stoi(token));
+      } else if constexpr (std::is_same_v<T, float>) {
+        result.push_back(std::stof(token));
       } else if constexpr (std::is_same_v<T, std::string>) {
         result.push_back(token);
       }
@@ -66,6 +68,11 @@ class ITSDecodingErrorCheck : public o2::quality_control::checker::CheckInterfac
   }
 
  private:
+  int nCycle = 0;
+  // set timer
+  std::chrono::time_point<std::chrono::high_resolution_clock> start;
+  std::chrono::time_point<std::chrono::high_resolution_clock> end;
+  int TIME = 1;
   ClassDefOverride(ITSDecodingErrorCheck, 1);
 
   std::shared_ptr<TLatex> tInfo;

Modules/ITS/itsDecoding.json

@@ -48,6 +48,8 @@
                 "detectorName": "ITS",
                 "checkParameters": {
                       "DecLinkErrorLimits": "1, 1, 1, 1, 1, 1000, 1000, 1000, 1000, 1000, 1000, 1, 1, 1000, 1000, 1, 1, 1, 1, 1000, 1000, 50, 50",
+                      "DecLinkErrorLimitsRatio": "0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0.1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0",
+                      "DecLinkErrorType": "0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 1, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0",
                       "plotWithTextMessage": "",
                       "textMessage": ""
                 },

Modules/ITS/src/ITSDecodingErrorCheck.cxx

@@ -30,14 +30,31 @@ namespace o2::quality_control_modules::its
 
 Quality ITSDecodingErrorCheck::check(std::map<std::string, std::shared_ptr<MonitorObject>>* moMap)
 {
+  // set timer
+  if (nCycle == 0) {
+    start = std::chrono::high_resolution_clock::now();
+    nCycle++;
+  } else {
+    end = std::chrono::high_resolution_clock::now();
+    TIME = std::chrono::duration_cast<std::chrono::seconds>(end - start).count();
+  }
   std::vector<int> vDecErrorLimits = convertToArray<int>(o2::quality_control_modules::common::getFromConfig<string>(mCustomParameters, "DecLinkErrorLimits", ""));
   if (vDecErrorLimits.size() != o2::itsmft::GBTLinkDecodingStat::NErrorsDefined) {
     LOG(error) << "Incorrect vector with DecodingError limits, check .json" << ENDM;
     doFlatCheck = true;
   }
+  std::vector<float> vDecErrorLimitsRatio = convertToArray<float>(o2::quality_control_modules::common::getFromConfig<string>(mCustomParameters, "DecLinkErrorLimitsRatio", ""));
+  if (vDecErrorLimitsRatio.size() != o2::itsmft::GBTLinkDecodingStat::NErrorsDefined) {
+    LOG(error) << "Incorrect vector with DecodingError limits Ratio, check .json" << ENDM;
+    doFlatCheck = true;
+  }
+  std::vector<int> vDecErrorType = convertToArray<int>(o2::quality_control_modules::common::getFromConfig<string>(mCustomParameters, "DecLinkErrorType", ""));
+  if (vDecErrorType.size() != o2::itsmft::GBTLinkDecodingStat::NErrorsDefined) {
+    LOG(error) << "Incorrect vector with DecodingError Type, check .json" << ENDM;
+    doFlatCheck = true;
+  }
 
   Quality result = Quality::Null;
-
   for (auto& [moName, mo] : *moMap) {
     (void)moName;
     if (mo->getName() == "General/ChipErrorPlots") {
@@ -60,15 +77,30 @@ Quality ITSDecodingErrorCheck::check(std::map<std::string, std::shared_ptr<Monit
 
           if (vDecErrorLimits[iBin - 1] < 0)
             continue; // skipping bin
-          if (vDecErrorLimits[iBin - 1] <= h->GetBinContent(iBin)) {
-            vListErrorIdBad.push_back(iBin - 1);
-            result.set(Quality::Bad);
-            result.addReason(o2::quality_control::FlagReasonFactory::Unknown(), Form("BAD: ID = %d, %s", iBin - 1, std::string(statistics.ErrNames[iBin - 1]).c_str()));
-          } else if (vDecErrorLimits[iBin - 1] / 2 < h->GetBinContent(iBin)) {
-            vListErrorIdMedium.push_back(iBin - 1);
-            if (result != Quality::Bad) {
-              result.addReason(o2::quality_control::FlagReasonFactory::Unknown(), Form("Medium: ID = %d, %s", iBin - 1, std::string(statistics.ErrNames[iBin - 1]).c_str()));
-              result.set(Quality::Medium);
+
+          if (vDecErrorType[iBin - 1] == 1 && TIME != 0) {
+            if (vDecErrorLimitsRatio[iBin - 1] <= h->GetBinContent(iBin) / TIME) {
+              vListErrorIdBad.push_back(iBin - 1);
+              result.set(Quality::Bad);
+              result.addReason(o2::quality_control::FlagReasonFactory::Unknown(), Form("BAD: ID = %d, %s", iBin - 1, std::string(statistics.ErrNames[iBin - 1]).c_str()));
+            } else if (vDecErrorLimitsRatio[iBin - 1] / 2 < h->GetBinContent(iBin) / TIME) {
+              vListErrorIdMedium.push_back(iBin - 1);
+              if (result != Quality::Bad) {
+                result.addReason(o2::quality_control::FlagReasonFactory::Unknown(), Form("Medium: ID = %d, %s", iBin - 1, std::string(statistics.ErrNames[iBin - 1]).c_str()));
+                result.set(Quality::Medium);
+              }
+            }
+          } else { // normal check, as we have in the code now
+            if (vDecErrorLimits[iBin - 1] <= h->GetBinContent(iBin)) {
+              vListErrorIdBad.push_back(iBin - 1);
+              result.set(Quality::Bad);
+              result.addReason(o2::quality_control::FlagReasonFactory::Unknown(), Form("BAD: ID = %d, %s", iBin - 1, std::string(statistics.ErrNames[iBin - 1]).c_str()));
+            } else if (vDecErrorLimits[iBin - 1] / 2 < h->GetBinContent(iBin)) {
+              vListErrorIdMedium.push_back(iBin - 1);
+              if (result != Quality::Bad) {
+                result.addReason(o2::quality_control::FlagReasonFactory::Unknown(), Form("Medium: ID = %d, %s", iBin - 1, std::string(statistics.ErrNames[iBin - 1]).c_str()));
+                result.set(Quality::Medium);
+              }
             }
           }
         }