Tracklet per trigger check trend and gloabl quality (#1957)

* TrackletPerTriggerCheck-Trend-and-Gloabl-Quality

* clang-formatting

* restoring changes in json

* restoring other changes in TRDQC.json

Author: deependra170598

Modules/TRD/TRDQC.json

@@ -129,7 +129,7 @@
         "checkParameters":{
           "Lowerthreshold":"500.0",
           "Upperthreshold":"520.0",
-          "StatThreshold": "1"
+          "StatThreshold": "1000"
         }
       }
     },

Modules/TRD/include/TRD/TrackletPerTriggerCheck.h

@@ -38,12 +38,12 @@ class TrackletPerTriggerCheck : public o2::quality_control::checker::CheckInterf
   void beautify(std::shared_ptr<MonitorObject> mo, Quality checkResult = Quality::Null) override;
   std::string getAcceptedType() override;
   long int mTimeStamp;
-  std::pair<float, float> DesiredMeanRegion;
-  long int StatThreshold;
+  std::pair<float, float> mDesiredMeanRegion;
+  long int mStatThreshold;
 
   ClassDefOverride(TrackletPerTriggerCheck, 2);
 };
 
 } // namespace o2::quality_control_modules::trd
 
-#endif // QC_MODULE_TRD_TRDTRACKLETPERTRIGGERCHECK_H
+#endif // QC_MODULE_TRD_TRDTRACKLETPERTRIGGERCHECK_H

Modules/TRD/src/RawData.cxx

@@ -199,7 +199,7 @@ void RawData::monitorData(o2::framework::ProcessingContext& ctx)
 {
 
   auto rawdatastats = ctx.inputs().get<o2::trd::TRDDataCountersPerTimeFrame*>("rawstats");
-  mStats->AddBinContent(1, 1);                     // count number of TFs seen
+  mStats->AddBinContent(1, 1);                             // count number of TFs seen
   mStats->AddBinContent(2, rawdatastats->mNTriggersTotal); // count total number of triggers seen
   mStats->AddBinContent(3, rawdatastats->mNTriggersCalib); // count total number of calibration triggers seen
   mStats->AddBinContent(4, rawdatastats->mTrackletsFound); // count total number of tracklets seen

Modules/TRD/src/TrackletPerTriggerCheck.cxx

@@ -20,11 +20,11 @@
 #include "QualityControl/QcInfoLogger.h"
 // ROOT
 #include <TH1.h>
-#include "TString.h"
-#include "TPaveText.h"
+#include <TString.h>
+#include <TPaveText.h>
 
 #include <DataFormatsQualityControl/FlagReasons.h>
-#include "CCDB/BasicCCDBManager.h"
+#include <CCDB/BasicCCDBManager.h>
 
 using namespace std;
 using namespace o2::quality_control;
@@ -48,71 +48,66 @@ void TrackletPerTriggerCheck::configure()
   ILOG(Debug, Devel) << "initialize TrackletPertriggerCheck" << ENDM; // QcInfoLogger is used. FairMQ logs will go to there as well.
 
   if (auto param = mCustomParameters.find("Lowerthreshold"); param != mCustomParameters.end()) {
-    DesiredMeanRegion.first = stof(param->second);
-    ILOG(Debug, Support) << "configure() : using json Lowerthreshold" << DesiredMeanRegion.first << ENDM;
+    mDesiredMeanRegion.first = stof(param->second);
+    ILOG(Debug, Support) << "configure() : using json Lowerthreshold" << mDesiredMeanRegion.first << ENDM;
   } else {
-    DesiredMeanRegion.first = 500.0;
-    ILOG(Debug, Support) << "configure() : using default Lowerthreshold" << DesiredMeanRegion.first << ENDM;
+    mDesiredMeanRegion.first = 500.0;
+    ILOG(Debug, Support) << "configure() : using default Lowerthreshold" << mDesiredMeanRegion.first << ENDM;
   }
 
   if (auto param = mCustomParameters.find("Upperthreshold"); param != mCustomParameters.end()) {
-    DesiredMeanRegion.second = stof(param->second);
-    ILOG(Debug, Support) << "configure() : using json Upperthreshold" << DesiredMeanRegion.second << ENDM;
+    mDesiredMeanRegion.second = stof(param->second);
+    ILOG(Debug, Support) << "configure() : using json Upperthreshold" << mDesiredMeanRegion.second << ENDM;
   } else {
-    DesiredMeanRegion.second = 520.0;
-    ILOG(Debug, Support) << "configure() : using default Upperthreshold" << DesiredMeanRegion.second << ENDM;
+    mDesiredMeanRegion.second = 520.0;
+    ILOG(Debug, Support) << "configure() : using default Upperthreshold" << mDesiredMeanRegion.second << ENDM;
   }
 
   if (auto param = mCustomParameters.find("StatThreshold"); param != mCustomParameters.end()) {
-    StatThreshold = stod(param->second);
-    ILOG(Debug, Support) << "configure() : using json StatThreshold" << StatThreshold << ENDM;
+    mStatThreshold = stod(param->second);
+    ILOG(Debug, Support) << "configure() : using json mStatThreshold" << mStatThreshold << ENDM;
   } else {
-    StatThreshold = 1000;
-    ILOG(Debug, Support) << "configure() : using default StatThreshold" << StatThreshold << ENDM;
+    mStatThreshold = 1000;
+    ILOG(Debug, Support) << "configure() : using default mStatThreshold" << mStatThreshold << ENDM;
   }
 }
 
 Quality TrackletPerTriggerCheck::check(std::map<std::string, std::shared_ptr<MonitorObject>>* moMap)
 {
   Quality result = Quality::Null;
 
-  // you can get details about the activity via the object mActivity:
-  ILOG(Debug, Devel) << "Run " << getActivity()->mId << ", type: " << getActivity()->mType << ", beam: " << getActivity()->mBeamType << ENDM;
-  // and you can get your custom parameters:
-  ILOG(Debug, Devel) << "custom param physics.pp.myOwnKey1 : " << mCustomParameters.atOrDefaultValue("myOwnKey1", "physics", "pp", "default_value") << ENDM;
-
   for (auto& [moName, mo] : *moMap) {
-
     (void)moName;
     if (mo->getName() == "trackletsperevent") {
       auto* h = dynamic_cast<TH1F*>(mo->getObject());
-
+      if (h == nullptr) {
+        // ILOG(Debug, Support) << "Requested Histogram type does not match with the Histogram in source" << ENDM;
+        continue;
+      }
       // writing text over hist
       TPaveText* msg1 = new TPaveText(0.3, 0.7, 0.7, 0.9, "NDC"); // check option "br","NDC"
       h->GetListOfFunctions()->Add(msg1);
       msg1->SetTextSize(10);
       int Entries = h->GetEntries();
-      if (Entries > StatThreshold) {
-        msg1->AddText(TString::Format("Hist Can't be ignored. Stat is enough. Entries: %d > Threshold: %d", Entries, StatThreshold));
+      if (Entries > mStatThreshold) {
+        msg1->AddText(TString::Format("Hist Can't be ignored. Stat is enough. Entries: %d > Threshold: %d", Entries, mStatThreshold));
         // msg1->SetTextColor(kGreen);
       } else if (Entries > 0) {
-        msg1->AddText(TString::Format("Hist Can be ignored. Stat is low. Entries: %d < Threshold: %d", Entries, StatThreshold));
+        msg1->AddText(TString::Format("Hist Can be ignored. Stat is low. Entries: %d < Threshold: %d", Entries, mStatThreshold));
         // msg1->SetTextColor(kYellow);
       } else if (Entries == 0) {
-        msg1->AddText(TString::Format("Hist is empty. Entries: %d < Threshold: %d", Entries, StatThreshold));
+        msg1->AddText(TString::Format("Hist is empty. Entries: %d < Threshold: %d", Entries, mStatThreshold));
         msg1->SetTextColor(kRed);
       }
 
       // applying check
       float MeanTracletPertrigger = h->GetMean();
-      if (MeanTracletPertrigger > DesiredMeanRegion.second && MeanTracletPertrigger < DesiredMeanRegion.first) {
+      if (MeanTracletPertrigger > mDesiredMeanRegion.second && MeanTracletPertrigger < mDesiredMeanRegion.first) {
         result = Quality::Good;
       } else {
         result = Quality::Bad;
         result.addReason(FlagReasonFactory::Unknown(), "MeanTracletPertrigger is not in bound region");
       }
-
-      result.addMetadata("mykey", "myvalue");
     }
   }
   return result;
@@ -124,7 +119,10 @@ void TrackletPerTriggerCheck::beautify(std::shared_ptr<MonitorObject> mo, Qualit
 {
   if (mo->getName() == "trackletsperevent") {
     auto* h = dynamic_cast<TH1F*>(mo->getObject());
-
+    if (h == nullptr) {
+      // ILOG(Debug, Support) << "Requested Histogram type does not match with the Histogram in source" << ENDM;
+      return;
+    }
     if (checkResult == Quality::Good) {
       h->SetFillColor(kGreen);
     } else if (checkResult == Quality::Bad) {
@@ -138,4 +136,4 @@ void TrackletPerTriggerCheck::beautify(std::shared_ptr<MonitorObject> mo, Qualit
   }
 }
 
-} // namespace o2::quality_control_modules::trd
+} // namespace o2::quality_control_modules::trd