Skip to content

Commit 290a06e

Browse files
authored
update monitoring metrics (#349)
* update monitoring metrics * block->message, unify naming of monitoring metrics
1 parent 795e686 commit 290a06e

2 files changed

Lines changed: 15 additions & 12 deletions

File tree

Framework/include/QualityControl/TaskRunner.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -138,9 +138,9 @@ class TaskRunner : public framework::Task
138138
int mCycleNumber = 0;
139139

140140
// stats
141-
int mNumberBlocks = 0;
141+
int mNumberMessages = 0;
142142
int mNumberObjectsPublishedInCycle = 0;
143-
int mTotalNumberObjectsPublished = 0;
143+
int mTotalNumberObjectsPublished = 0; // over a run
144144
double mLastPublicationDuration = 0;
145145
AliceO2::Common::Timer mTimerTotalDurationActivity;
146146
AliceO2::Common::Timer mTimerDurationCycle;

Framework/src/TaskRunner.cxx

Lines changed: 13 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ void TaskRunner::run(ProcessingContext& pCtx)
101101

102102
if (dataReady) {
103103
mTask->monitorData(pCtx);
104-
mNumberBlocks++;
104+
mNumberMessages++;
105105
}
106106

107107
if (timerReady) {
@@ -324,7 +324,10 @@ std::string TaskRunner::validateDetectorName(std::string name)
324324

325325
void TaskRunner::startOfActivity()
326326
{
327+
// stats
327328
mTimerTotalDurationActivity.reset();
329+
mTotalNumberObjectsPublished = 0;
330+
328331
Activity activity(mConfigFile->get<int>("qc.config.Activity.number"),
329332
mConfigFile->get<int>("qc.config.Activity.type"));
330333
mTask->startOfActivity(activity);
@@ -346,7 +349,7 @@ void TaskRunner::startCycle()
346349
{
347350
QcInfoLogger::GetInstance() << "cycle " << mCycleNumber << " in " << mTaskConfig.taskName << AliceO2::InfoLogger::InfoLogger::endm;
348351
mTask->startOfCycle();
349-
mNumberBlocks = 0;
352+
mNumberMessages = 0;
350353
mNumberObjectsPublishedInCycle = 0;
351354
mTimerDurationCycle.reset();
352355
mCycleOn = true;
@@ -379,14 +382,14 @@ void TaskRunner::publishCycleStats()
379382
double totalDurationActivity = mTimerTotalDurationActivity.getTime();
380383

381384
// monitoring metrics
382-
mCollector->send({ mNumberBlocks, "QC_task_Numberofblocks_in_cycle" });
383-
mCollector->send({ cycleDuration, "QC_task_Module_cycle_duration" });
384-
mCollector->send({ mLastPublicationDuration, "QC_task_Publication_duration" });
385-
mCollector->send({ mNumberObjectsPublishedInCycle, "QC_task_Number_objects_published_in_cycle" });
386-
mCollector->send({ rate, "QC_task_Rate_objects_published_per_second" });
387-
mCollector->send({ mTotalNumberObjectsPublished, "QC_task_Total_objects_published_whole_run" });
388-
mCollector->send({ totalDurationActivity, "QC_task_Total_duration_activity_whole_run" });
389-
mCollector->send({ wholeRunRate, "QC_task_Rate_objects_published_per_second_whole_run" });
385+
mCollector->send({ mNumberMessages, "QC_task_number_messages_received_in_cycle" });
386+
mCollector->send({ cycleDuration, "QC_task_module_cycle_duration" });
387+
mCollector->send({ mLastPublicationDuration, "QC_task_publication_duration" });
388+
mCollector->send({ mNumberObjectsPublishedInCycle, "QC_task_number_objects_published_in_cycle" });
389+
mCollector->send({ rate, "QC_task_rate_objects_published_per_second" });
390+
mCollector->send({ mTotalNumberObjectsPublished, "QC_task_total_objects_published_whole_run" });
391+
mCollector->send({ totalDurationActivity, "QC_task_total_duration_activity_whole_run" });
392+
mCollector->send({ wholeRunRate, "QC_task_rate_objects_published_per_second_whole_run" });
390393
}
391394

392395
int TaskRunner::publish(DataAllocator& outputs)

0 commit comments

Comments
 (0)