[QC-509] Clear warnings (#576)

Author: Barthelemy

Modules/ITS/src/ITSClusterCheck.cxx

@@ -31,10 +31,9 @@ void ITSClusterCheck::configure(std::string) {}
 
 Quality ITSClusterCheck::check(std::map<std::string, std::shared_ptr<MonitorObject>>* moMap)
 {
-  auto mo = moMap->begin()->second;
   Quality result = Quality::Null;
   std::map<std::string, std::shared_ptr<MonitorObject>>::iterator iter;
-  for (iter = moMap->begin(); iter != moMap->end(); iter++) {
+  for (iter = moMap->begin(); iter != moMap->end(); ++iter) {
     if (iter->second->getName() == "Layer0/AverageClusterSize") {
       auto* h = dynamic_cast<TH2D*>(iter->second->getObject());
       if (h->GetMaximum() > 30) {
@@ -52,13 +51,13 @@ std::string ITSClusterCheck::getAcceptedType() { return "TH2D"; }
 void ITSClusterCheck::beautify(std::shared_ptr<MonitorObject> mo, Quality checkResult)
 {
   auto* h = dynamic_cast<TH2D*>(mo->getObject());
-  TText* tInfo;
+  auto* tInfo = new TText();
 
   if (checkResult == Quality::Good) {
-    tInfo = new TText(0.1, 0.8, "Quality::GOOD");
+    tInfo->SetText(0.1, 0.8, "Quality::GOOD");
     tInfo->SetTextColor(kGreen);
   } else if (checkResult == Quality::Bad) {
-    tInfo = new TText(0.1, 0.8, "Quality::BAD");
+    tInfo->SetText(0.1, 0.8, "Quality::BAD");
     tInfo->SetTextColor(kRed);
   }
   tInfo->SetTextSize(17);

Modules/ITS/src/ITSFeeCheck.cxx

@@ -30,10 +30,9 @@ void ITSFeeCheck::configure(std::string) {}
 
 Quality ITSFeeCheck::check(std::map<std::string, std::shared_ptr<MonitorObject>>* moMap)
 {
-  auto mo = moMap->begin()->second;
   Quality result = Quality::Null;
   std::map<std::string, std::shared_ptr<MonitorObject>>::iterator iter;
-  for (iter = moMap->begin(); iter != moMap->end(); iter++) {
+  for (iter = moMap->begin(); iter != moMap->end(); ++iter) {
     if (iter->second->getName() == "LaneStatus/laneStatusFlagFAULT") {
       auto* h = dynamic_cast<TH2I*>(iter->second->getObject());
       if (h->GetMaximum() > 0) {
@@ -51,13 +50,13 @@ std::string ITSFeeCheck::getAcceptedType() { return "TH2I"; }
 void ITSFeeCheck::beautify(std::shared_ptr<MonitorObject> mo, Quality checkResult)
 {
   auto* h = dynamic_cast<TH2I*>(mo->getObject());
-  TText* tInfo;
+  auto* tInfo = new TText();
 
   if (checkResult == Quality::Good) {
-    tInfo = new TText(0.1, 0.8, "Quality::GOOD");
+    tInfo->SetText(0.1, 0.8, "Quality::GOOD");
     tInfo->SetTextColor(kGreen);
   } else if (checkResult == Quality::Bad) {
-    tInfo = new TText(0.1, 0.8, "Quality::BAD");
+    tInfo->SetText(0.1, 0.8, "Quality::BAD");
     tInfo->SetTextColor(kRed);
   }
   tInfo->SetTextSize(17);

Modules/ITS/src/ITSFhrCheck.cxx

@@ -30,10 +30,9 @@ void ITSFhrCheck::configure(std::string) {}
 
 Quality ITSFhrCheck::check(std::map<std::string, std::shared_ptr<MonitorObject>>* moMap)
 {
-  auto mo = moMap->begin()->second;
   Quality result = Quality::Null;
   std::map<std::string, std::shared_ptr<MonitorObject>>::iterator iter;
-  for (iter = moMap->begin(); iter != moMap->end(); iter++) {
+  for (iter = moMap->begin(); iter != moMap->end(); ++iter) {
     if (iter->second->getName() == "General/ErrorPlots") {
       auto* h = dynamic_cast<TH1D*>(iter->second->getObject());
       if (h->GetMaximum() > 0) {
@@ -51,7 +50,7 @@ std::string ITSFhrCheck::getAcceptedType() { return "TH1"; }
 void ITSFhrCheck::beautify(std::shared_ptr<MonitorObject> mo, Quality checkResult)
 {
   auto* h = dynamic_cast<TH1D*>(mo->getObject());
-  TPaveText* msg = new TPaveText(0.5, 0.5, 0.9, 0.75, "NDC");
+  auto* msg = new TPaveText(0.5, 0.5, 0.9, 0.75, "NDC");
   msg->SetName(Form("%s_msg", mo->GetName()));
   if (checkResult == Quality::Good) {
     msg->Clear();

Modules/ITS/src/ITSTrackCheck.cxx

@@ -18,7 +18,6 @@
 #include "QualityControl/MonitorObject.h"
 #include "QualityControl/Quality.h"
 
-#include <fairlogger/Logger.h>
 #include <TList.h>
 #include <TH1.h>
 #include <TText.h>
@@ -30,10 +29,9 @@ void ITSTrackCheck::configure(std::string) {}
 
 Quality ITSTrackCheck::check(std::map<std::string, std::shared_ptr<MonitorObject>>* moMap)
 {
-  auto mo = moMap->begin()->second;
   Quality result = Quality::Null;
   std::map<std::string, std::shared_ptr<MonitorObject>>::iterator iter;
-  for (iter = moMap->begin(); iter != moMap->end(); iter++) {
+  for (iter = moMap->begin(); iter != moMap->end(); ++iter) {
     if (iter->second->getName() == "NClusters") {
       auto* h = dynamic_cast<TH1D*>(iter->second->getObject());
       if (h->GetMean() > 8) {
@@ -51,13 +49,13 @@ std::string ITSTrackCheck::getAcceptedType() { return "TH1D"; }
 void ITSTrackCheck::beautify(std::shared_ptr<MonitorObject> mo, Quality checkResult)
 {
   auto* h = dynamic_cast<TH1D*>(mo->getObject());
-  TText* tInfo;
+  auto* tInfo = new TText();
 
   if (checkResult == Quality::Good) {
-    tInfo = new TText(0.1, 0.8, "Quality::GOOD");
+    tInfo->SetText(0.1, 0.8, "Quality::GOOD");
     tInfo->SetTextColor(kGreen);
   } else if (checkResult == Quality::Bad) {
-    tInfo = new TText(0.1, 0.8, "Quality::BAD");
+    tInfo->SetText(0.1, 0.8, "Quality::BAD");
     tInfo->SetTextColor(kRed);
   }
   tInfo->SetTextSize(17);