MCH: improve digits task plots (#1081)

* [MCH] improvements to detector histograms

- added visualization of detector contour
- added per-DE H/V shifts
- improved visualization of quadrants plots
- fixed orientation of SLATs
- added ad-hoc indexing of DE IDs

* [MCH] improvements to digits task and checker

- added option for saving the plots to a local ROOT file
- improved separation between standard and experts plots
- added configurable min and max occupancy levels in checker
- improved plotting of per-DE occupancies

Author: aferrero2707

Modules/MUON/MCH/include/MCH/GlobalHistogram.h

@@ -31,6 +31,9 @@ namespace muonchambers
 
 std::string getHistoPath(int deId);
 
+int getDEindex(int de);
+int getDEindexMax();
+
 class DetectorHistogram
 {
  public:
@@ -59,8 +62,11 @@ class DetectorHistogram
 
   bool mFlipX{ false };
   bool mFlipY{ false };
+  float mShiftX{ 0 };
+  float mShiftY{ 0 };
 
   void init();
+  void addContour();
 };
 
 class GlobalHistogram : public TH2F

Modules/MUON/MCH/include/MCH/MergeableTH1OccupancyPerDE.h

@@ -37,6 +37,7 @@
 #include "MCHMappingInterface/Segmentation.h"
 #include "MCHMappingInterface/CathodeSegmentation.h"
 #include "MCHMappingSegContour/CathodeSegmentationContours.h"
+#include "MCH/GlobalHistogram.h"
 
 using namespace std;
 namespace o2::quality_control_modules::muonchambers
@@ -48,7 +49,7 @@ class MergeableTH1OccupancyPerDE : public TH1F, public o2::mergers::MergeInterfa
   MergeableTH1OccupancyPerDE() = default;
 
   MergeableTH1OccupancyPerDE(MergeableTH1OccupancyPerDE const& copymerge)
-    : TH1F("DefaultName", "DefaultTitle", 1100, -0.5, 1099.5), o2::mergers::MergeInterface()
+    : TH1F("DefaultName", "DefaultTitle", getDEindexMax(), 0, getDEindexMax()), o2::mergers::MergeInterface()
   {
     Bool_t bStatus = TH1::AddDirectoryStatus();
     TH1::AddDirectory(kFALSE);
@@ -58,12 +59,12 @@ class MergeableTH1OccupancyPerDE : public TH1F, public o2::mergers::MergeInterfa
   }
 
   MergeableTH1OccupancyPerDE(const char* name, const char* title)
-    : TH1F(name, title, 1100, -0.5, 1099.5), o2::mergers::MergeInterface()
+    : TH1F(name, title, getDEindexMax(), 0, getDEindexMax()), o2::mergers::MergeInterface()
   {
     Bool_t bStatus = TH1::AddDirectoryStatus();
     TH1::AddDirectory(kFALSE);
-    mHistoNum = new TH1F("num", "num", 1100, -0.5, 1099.5);
-    mHistoDen = new TH1F("den", "den", 1100, -0.5, 1099.5);
+    mHistoNum = new TH1F("num", "num", getDEindexMax(), 0, getDEindexMax());
+    mHistoDen = new TH1F("den", "den", getDEindexMax(), 0, getDEindexMax());
     TH1::AddDirectory(bStatus);
     update();
   }
@@ -136,7 +137,6 @@ class MergeableTH1OccupancyPerDE : public TH1F, public o2::mergers::MergeInterfa
       for (int biny = 1; biny < horbits->GetYaxis()->GetNbins() + 1; biny++) {
 
         int mNOrbits = horbits->GetBinContent(binx, biny);
-        //std::cout << fmt::format("  norbits {}", mNOrbits) << std::endl;
         if (mNOrbits <= 0) {
           // no orbits detected for this channel, skip it
           continue;
@@ -163,8 +163,9 @@ class MergeableTH1OccupancyPerDE : public TH1F, public o2::mergers::MergeInterfa
     }
 
     for (auto i : o2::mch::raw::deIdsForAllMCH) {
-      mHistoNum->SetBinContent(i + 1, nHitsDE[i]);
-      mHistoDen->SetBinContent(i + 1, nOrbitsDE[i]);
+      auto id = getDEindex(i);
+      mHistoNum->SetBinContent(id + 1, nHitsDE[i]);
+      mHistoDen->SetBinContent(id + 1, nOrbitsDE[i]);
     }
 
     update();
@@ -180,4 +181,4 @@ class MergeableTH1OccupancyPerDE : public TH1F, public o2::mergers::MergeInterfa
 
 } // namespace o2::quality_control_modules::muonchambers
 
-#endif //O2_MERGEABLETH1OCCUPANCYPERDE_H
+#endif // O2_MERGEABLETH1OCCUPANCYPERDE_H

Modules/MUON/MCH/include/MCH/PhysicsCheck.h

@@ -20,6 +20,8 @@
 #include "QualityControl/CheckInterface.h"
 #include "QualityControl/MonitorObject.h"
 #include "QualityControl/Quality.h"
+#include "MCHRawCommon/DataFormats.h"
+#include "MCHRawElecMap/Mapper.h"
 #include <string>
 
 namespace o2::quality_control_modules::muonchambers
@@ -43,9 +45,17 @@ class PhysicsCheck : public o2::quality_control::checker::CheckInterface
   std::string getAcceptedType() override;
 
  private:
+  bool checkPadMapping(uint16_t feeId, uint8_t linkId, uint8_t eLinkId, o2::mch::raw::DualSampaChannelId channel);
+
   int mPrintLevel;
-  double minOccupancy;
-  double maxOccupancy;
+  double mMinOccupancy;
+  double mMaxOccupancy;
+
+  o2::mch::raw::Elec2DetMapper mElec2DetMapper;
+  o2::mch::raw::Det2ElecMapper mDet2ElecMapper;
+  o2::mch::raw::FeeLink2SolarMapper mFeeLink2SolarMapper;
+  o2::mch::raw::Solar2FeeLinkMapper mSolar2FeeLinkMapper;
+
   ClassDefOverride(PhysicsCheck, 2);
 };
 

Modules/MUON/MCH/include/MCH/PhysicsTaskDigits.h

@@ -75,6 +75,7 @@ class PhysicsTaskDigits /*final*/ : public TaskInterface // todo add back the "f
   static constexpr int sMaxDsId = 40;
 
   bool mDiagnostic{ false };
+  bool mSaveToRootFile{ false };
 
   o2::mch::raw::Elec2DetMapper mElec2DetMapper;
   o2::mch::raw::Det2ElecMapper mDet2ElecMapper;
@@ -89,9 +90,9 @@ class PhysicsTaskDigits /*final*/ : public TaskInterface // todo add back the "f
   TH2F* mHistogramNorbitsElec;                                // Histogram of Number of orbits (Elec view)
   std::shared_ptr<MergeableTH2Ratio> mHistogramOccupancyElec; // Mergeable object, Occupancy histogram (Elec view)
 
-  std::shared_ptr<TH2F> mDigitsOrbitInTF;
-  std::shared_ptr<TH2F> mDigitsBcInOrbit;
-  std::shared_ptr<TH2F> mAmplitudeVsSamples;
+  std::shared_ptr<TH2F> mHistogramDigitsOrbitInTF;
+  std::shared_ptr<TH2F> mHistogramDigitsBcInOrbit;
+  std::shared_ptr<TH2F> mHistogramAmplitudeVsSamples;
 
   std::map<int, std::shared_ptr<TH1F>> mHistogramADCamplitudeDE;              // Histogram of ADC distribution per DE
   std::map<int, std::shared_ptr<DetectorHistogram>> mHistogramNhitsDE[2];     // Histogram of Number of hits (XY view)